Skip to content

test(linter/plugins): conformance tester add summary of failing tests to report#16740

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report
Dec 11, 2025
Merged

test(linter/plugins): conformance tester add summary of failing tests to report#16740
graphite-app[bot] merged 1 commit intomainfrom
12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Dec 11, 2025

Add a summary of rules with failing tests to the snapshot report, so can easily see which rules have the most failures.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 11, 2025
Copy link
Copy Markdown
Member Author

overlookmotel commented Dec 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the conformance testing report by adding a summary list of all failing rules with their pass rates at the beginning of the "Rules with Failures" section, before the detailed breakdown. This makes it easy to quickly see which rules have the most failures without scrolling through detailed error information.

Key Changes

  • Added a summary list showing each failing rule with its pass rate as "passed / total (percentage%)"
  • Renamed the detailed failures section to "Rules with Failures Detail" to distinguish it from the summary
  • The snapshot file now includes the new summary format showing all 100 failing rules in a concise list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/oxlint/conformance/src/report.ts Added logic to generate a summary list of failing rules with pass rates before the detailed breakdown
apps/oxlint/conformance/snapshot.md Updated snapshot to include the new summary section with 100 failing rules listed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 11, 2025
@graphite-app graphite-app bot force-pushed the 12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report branch 2 times, most recently from ee0f103 to 6c6af18 Compare December 11, 2025 11:25
@graphite-app graphite-app bot force-pushed the 12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report branch from 4baa91e to 71632c6 Compare December 11, 2025 11:25
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Dec 11, 2025

Merge activity

@overlookmotel overlookmotel force-pushed the 12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report branch from 71632c6 to 339b30a Compare December 11, 2025 11:48
@overlookmotel overlookmotel force-pushed the 12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report branch from 6c6af18 to 5bcc2cd Compare December 11, 2025 11:48
… to report (#16740)

Add a summary of rules with failing tests to the snapshot report, so can easily see which rules have the most failures.
@graphite-app graphite-app bot force-pushed the 12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report branch from 5bcc2cd to e8290b1 Compare December 11, 2025 11:50
@graphite-app graphite-app bot force-pushed the 12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report branch from 339b30a to 9a964da Compare December 11, 2025 11:50
Base automatically changed from 12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report to main December 11, 2025 11:56
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 11, 2025
@graphite-app graphite-app bot merged commit 9a964da into main Dec 11, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 12-11-test_linter_plugins_conformance_tester_add_summary_of_failing_tests_to_report branch December 11, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants