test(linter/plugins): conformance tester avoid repeated loops creating report#16739
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 11, 2025
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the conformance tester to improve performance and readability by categorizing rule results once upfront rather than repeatedly looping through the same arrays 10+ times. The changes eliminate redundant array filtering operations when generating the markdown report and calculating summary statistics.
Key changes:
- Introduced single-pass categorization of rules into
loadErrorRules,noTestRules,passingRules, andfailingRulesarrays - Replaced multiple
filter()andreduce()operations with direct array length access - Extracted repeated percentage formatting logic into a
formatProportion()helper function
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
apps/oxlint/conformance/src/report.ts |
Refactored to categorize rules once at the start of generateReport(), replacing 10+ filter operations; added formatProportion() helper |
apps/oxlint/conformance/src/run.ts |
Changed from filter().length to reduce() for counting passed tests in console output |
apps/oxlint/conformance/src/main.ts |
Replaced filter operations with a single loop to count load errors and fully passing rules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
graphite-app
bot
changed the base branch from
12-11-test_linter_plugins_fix_garbled_output_from_assertions
to
graphite-base/16739
graphite-app
bot
force-pushed
the
graphite-base/16739
branch
from
69f77ec to
4416b34
Compare
graphite-app
bot
force-pushed
the
12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report
branch
from
90b1406 to
ee0f103
Compare
graphite-app
bot
force-pushed
the
12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report
branch
from
ee0f103 to
6c6af18
Compare
Contributor
Merge activity
|
overlookmotel
force-pushed
the
12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report
branch
from
6c6af18 to
5bcc2cd
Compare
…g report (#16739) Pure refactor to conformance tester. The code written by Claude looped over the same arrays 10+ times, and was hard to read. Instead, categorize rule results once at the start of preparing the report. Ditto for summary stats output to `stdout`.
graphite-app
bot
force-pushed
the
12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report
branch
from
5bcc2cd to
e8290b1
Compare
graphite-app
bot
deleted the
12-11-test_linter_plugins_conformance_tester_avoid_repeated_loops_creating_report
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor to conformance tester. The code written by Claude looped over the same arrays 10+ times, and was hard to read. Instead, categorize rule results once at the start of preparing the report. Ditto for summary stats output to
stdout.