Skip to content

feat(oxfmt): Support quoteProps: consistent in Oxfmtrc#16721

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-11-feat_oxfmt_support_quoteprops_consistent
Dec 11, 2025
Merged

feat(oxfmt): Support quoteProps: consistent in Oxfmtrc#16721
graphite-app[bot] merged 1 commit intomainfrom
12-11-feat_oxfmt_support_quoteprops_consistent

Conversation

@leaysgur
Copy link
Copy Markdown
Member

@leaysgur leaysgur commented Dec 11, 2025 •
edited
Loading

Follow up #16677, fixes #16247.

Copilot AI review requested due to automatic review settings December 11, 2025 01:54
@leaysgur leaysgur requested a review from Dunqing as a code owner December 11, 2025 01:54
@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Dec 11, 2025
@leaysgur Graphite App
Copy link
Copy Markdown
Member Author

leaysgur commented Dec 11, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title feat(oxfmt): Support quoteProps: consistent feat(oxfmt): Support quoteProps: consistent in Oxfmtrc Dec 11, 2025
Copilot AI reviewed Dec 11, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables support for the quoteProps: "consistent" formatter option in oxfmt. The underlying implementation for consistent quote properties already exists in the formatter; this PR exposes it through the configuration layer by adding the "consistent" option to schemas and configuration mappings.

Key changes:

  • Added "consistent" to the QuotePropsConfig enum and JSON schemas
  • Updated configuration mapping to handle QuotePropsConfig::Consistent
  • Removed the "NOTE: 'consistent' is not supported" comment

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tasks/coverage/acorn-test262 Removed subproject reference (unrelated to feature)
npm/oxfmt/configuration_schema.json Added "consistent" option to QuotePropsConfig enum in schema
napi/playground/src/options.rs Updated documentation to include "consistent" option
crates/oxc_formatter/tests/snapshots/schema_json.snap Updated test snapshot to reflect schema changes
crates/oxc_formatter/src/service/oxfmtrc.rs Added QuotePropsConfig::Consistent enum variant and mapping logic; removed unsupported comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@leaysgur leaysgur force-pushed the 12-11-feat_oxfmt_support_quoteprops_consistent branch from 1350f5e to d800fb2 Compare December 11, 2025 01:57
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 11, 2025

CodSpeed Performance Report

Merging #16721 will not alter performance

Comparing 12-11-feat_oxfmt_support_quoteprops_consistent (d800fb2) with main (e973965)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 11, 2025
@Dunqing Graphite App
Copy link
Copy Markdown
Member

Dunqing commented Dec 11, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 12-11-feat_oxfmt_support_quoteprops_consistent branch from d800fb2 to afd6c44 Compare December 11, 2025 02:03
@graphite-app graphite-app bot merged commit afd6c44 into main Dec 11, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 12-11-feat_oxfmt_support_quoteprops_consistent branch December 11, 2025 02:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 11, 2025
@leaysgur leaysgur mentioned this pull request Dec 11, 2025
Closed
@Boshen Boshen mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Dunqing Dunqing Dunqing approved these changes

Assignees

@Dunqing Dunqing

Labels

A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

formatter: Support quoteProps: "consistent" option

3 participants

@leaysgur @Dunqing