refactor(linter/plugins): reduce code nesting#16719
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 11, 2025
Merged
Conversation
This was referenced Dec 11, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the getParseOptions function by reducing code nesting through early returns and flattening nested conditional blocks. The refactoring makes the code more readable without changing its behavior.
Key Changes:
- Introduced early return when
languageOptionsis null to eliminate the outermost nesting level - Flattened the error-throwing logic for custom parsers by removing unnecessary nesting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
12-11-refactor_linter_plugins_reduce_code_nesting
branch
from
5fc1eb8 to
f509ef4
Compare
overlookmotel
force-pushed
the
12-11-fix_linter_plugins_correct_punctuation_in_error_message
branch
from
849f5bd to
e1eebb7
Compare
Contributor
Merge activity
|
Pure refactor. Flatten a large `if` block, to make the code easier to follow.
graphite-app
bot
force-pushed
the
12-11-fix_linter_plugins_correct_punctuation_in_error_message
branch
from
e1eebb7 to
32e23f7
Compare
graphite-app
bot
force-pushed
the
12-11-refactor_linter_plugins_reduce_code_nesting
branch
from
f509ef4 to
4d9e981
Compare
Base automatically changed from
12-11-fix_linter_plugins_correct_punctuation_in_error_message
to
main
December 11, 2025 02:25
graphite-app
bot
deleted the
12-11-refactor_linter_plugins_reduce_code_nesting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Flatten a large
ifblock, to make the code easier to follow.