fix(linter/plugins): correct punctuation in error message#16718
Conversation
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR corrects the punctuation in a TypeError message to align with the codebase convention of not including periods at the end of single-sentence error messages. The change removes the trailing period from the error message "Expected loc to be an object with integer line and column properties."
- Removes trailing period from a single-sentence TypeError message in
location.ts - Updates the conformance snapshot file to reflect the corrected error message
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/src-js/plugins/location.ts | Removes trailing period from TypeError message and reformats to single line |
| apps/oxlint/conformance/snapshot.md | Updates 59 test snapshot entries to reflect the corrected error message |
The changes look good and are consistent with the stated convention. The error message is properly corrected from having a period to not having one, and all snapshot occurrences have been updated accordingly. No issues found with this implementation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
12-11-fix_linter_plugins_correct_punctuation_in_error_message
branch
from
849f5bd to
e1eebb7
Compare
overlookmotel
force-pushed
the
12-09-test_linter_plugins_conformance_tests_ignore_parsing_errors
branch
from
f0a3eb7 to
20b5b7c
Compare
Merge activity
|
Tiny change. Our convention is not to have full stops on end of error messages, unless they have multiple sentences. Alter this one to make it consistent with that style.
graphite-app
bot
force-pushed
the
12-09-test_linter_plugins_conformance_tests_ignore_parsing_errors
branch
from
20b5b7c to
7b28b6f
Compare
graphite-app
bot
force-pushed
the
12-11-fix_linter_plugins_correct_punctuation_in_error_message
branch
from
e1eebb7 to
32e23f7
Compare
graphite-app
bot
deleted the
12-11-fix_linter_plugins_correct_punctuation_in_error_message
branch
Tiny change. Our convention is not to have full stops on end of error messages, unless they have multiple sentences. Alter this one to make it consistent with that style.