test(linter/plugins): conformance tests ignore parsing errors#16717
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 11, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 11, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves conformance test compatibility with ESLint's test suite by enabling non-fatal parsing error handling. ESLint test cases often include intentionally invalid code (e.g., syntax errors, duplicate parameters) to verify that rules correctly handle edge cases. By setting parserOptions.ignoreNonFatalErrors = true, the parser can produce valid ASTs from code with non-fatal errors, allowing these tests to proceed and rules to be evaluated.
Key changes:
- Modified conformance test setup to unconditionally set
ignoreNonFatalErrors = truefor all test cases - Refactored test case modification logic to create new
languageOptionsandparserOptionsobjects before TypeScript parser handling - Improved test pass rates: 177 rules now fully passing (up from 171), with 69 additional tests passing overall
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/conformance/src/rule_tester.ts | Refactored modifyTestCase to unconditionally enable ignoreNonFatalErrors for all conformance tests, and restructured object creation to happen before TypeScript parser detection |
| apps/oxlint/conformance/snapshot.md | Updated test results showing improved pass rates across multiple rules (accessor-pairs, class-methods-use-this, default-param-last, func-style, grouped-accessor-pairs, init-declarations, no-array-constructor, no-dupe-class-members, no-restricted-imports, no-shadow-restricted-names, no-useless-constructor, prefer-arrow-callback, strict) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
12-11-test_linter_plugins_conformance_tester_error_on_test_cases_with_custom_parsers
branch
from
632bd1b to
ee3aae5
Compare
overlookmotel
force-pushed
the
12-09-test_linter_plugins_conformance_tests_ignore_parsing_errors
branch
from
f0a3eb7 to
20b5b7c
Compare
Contributor
Merge activity
|
ESLint's has many test cases with invalid code. Loosen parsing in conformance test, so parsing only errors if there's a fatal error, and allow any other error where parser can produce a valid AST.
graphite-app
bot
force-pushed
the
12-11-test_linter_plugins_conformance_tester_error_on_test_cases_with_custom_parsers
branch
from
ee3aae5 to
773d34d
Compare
graphite-app
bot
force-pushed
the
12-09-test_linter_plugins_conformance_tests_ignore_parsing_errors
branch
from
20b5b7c to
7b28b6f
Compare
Base automatically changed from
12-11-test_linter_plugins_conformance_tester_error_on_test_cases_with_custom_parsers
to
main
December 11, 2025 02:23
graphite-app
bot
deleted the
12-09-test_linter_plugins_conformance_tests_ignore_parsing_errors
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint's has many test cases with invalid code. Loosen parsing in conformance test, so parsing only errors if there's a fatal error, and allow any other error where parser can produce a valid AST.