Skip to content

test(linter/plugins): correct comment in conformance tester#16714

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-10-test_linter_plugins_correct_comment_in_conformance_tester
Dec 10, 2025
Merged

test(linter/plugins): correct comment in conformance tester#16714
graphite-app[bot] merged 1 commit intomainfrom
12-10-test_linter_plugins_correct_comment_in_conformance_tester

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Dec 10, 2025 •
edited
Loading

Tiny change. Just correct a comment.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 10, 2025
@overlookmotel overlookmotel mentioned this pull request Dec 10, 2025
Merged
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Dec 10, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Dec 10, 2025
Merged
@overlookmotel overlookmotel marked this pull request as ready for review December 10, 2025 18:36
Copilot AI review requested due to automatic review settings December 10, 2025 18:36
@overlookmotel overlookmotel self-assigned this Dec 10, 2025
Copilot AI reviewed Dec 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects and expands the documentation comment explaining the behavior of ESLint compatibility mode in the conformance tester. The change clarifies that enabling eslintCompat not only adjusts column indexes in diagnostics to match ESLint's behavior but also enables support for sourceType: "commonjs".

Key Changes

  • Enhanced documentation comment to include both effects of eslintCompat flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 10, 2025
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Dec 10, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 12-10-test_linter_plugins_conformance_tests_parse_as_tsx_where_specified branch from c0315f4 to fe372de Compare December 10, 2025 18:53
@graphite-app graphite-app bot force-pushed the 12-10-test_linter_plugins_correct_comment_in_conformance_tester branch from 92940c9 to 9c573ec Compare December 10, 2025 18:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 10, 2025
Base automatically changed from 12-10-test_linter_plugins_conformance_tests_parse_as_tsx_where_specified to main December 10, 2025 18:59
@graphite-app graphite-app bot merged commit 9c573ec into main Dec 10, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 12-10-test_linter_plugins_correct_comment_in_conformance_tester branch December 10, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel