test(linter/plugins): conformance tests parse as TSX where specified#16713
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 10, 2025
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes parsing of JSX code in TypeScript conformance tests by detecting when @typescript-eslint/parser is used with JSX enabled and setting the language to "tsx" instead of "ts".
- Conditionally sets
parserOptions.langto "tsx" whenecmaFeatures.jsx === true, otherwise defaults to "ts" - Fixes 5 conformance test failures (1 in
no-unused-expressions, 4 inno-use-before-define)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/conformance/src/rule_tester.ts | Modified modifyTestCase to check ecmaFeatures.jsx flag and set language to "tsx" or "ts" accordingly |
| apps/oxlint/conformance/snapshot.md | Updated test results showing 5 additional passing tests (from 28660 to 28665) and corresponding failure reduction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
…16713) Parse test cases as TSX where parser is specified as `@typescript-eslint/parser`, and `parserOptions.ecmaFeatures.jsx === true`.
graphite-app
bot
force-pushed
the
12-10-fix_linter_plugins_do_not_escape_tab_or_cr_in_test_case_names_in_ruletester_
branch
from
d432e70 to
6832464
Compare
graphite-app
bot
force-pushed
the
12-10-test_linter_plugins_conformance_tests_parse_as_tsx_where_specified
branch
from
c0315f4 to
fe372de
Compare
Base automatically changed from
12-10-fix_linter_plugins_do_not_escape_tab_or_cr_in_test_case_names_in_ruletester_
to
main
December 10, 2025 18:59
graphite-app
bot
deleted the
12-10-test_linter_plugins_conformance_tests_parse_as_tsx_where_specified
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse test cases as TSX where parser is specified as
@typescript-eslint/parser, andparserOptions.ecmaFeatures.jsx === true.