fix(formatter): should not insert a semicolon for non-property signatures when no semicolon is set#16700
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 11, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
CodSpeed Performance ReportMerging #16700 will not alter performanceComparing Summary
Footnotes
|
Dunqing
force-pushed
the
12-10-fix_formatter_should_not_insert_a_semicolon_for_method_signatures_when_no_semicolon_is_set
branch
from
2c85bfc to
aceb727
Compare
graphite-app
bot
changed the base branch from
12-10-feat_formatter_support_consistent_quote_props
to
graphite-base/16700
leaysgur
approved these changes
Dec 11, 2025
Member
Merge activity
|
…ures when no semicolon is set (#16700) Prettier issue: prettier/prettier#14040 Only property signatures would conflict with the following signatures in some situations, so return early if the current signature is not a property when `no-semi` is set.
graphite-app
bot
force-pushed
the
12-10-fix_formatter_should_not_insert_a_semicolon_for_method_signatures_when_no_semicolon_is_set
branch
from
aceb727 to
2a63d74
Compare
graphite-app
bot
deleted the
12-10-fix_formatter_should_not_insert_a_semicolon_for_method_signatures_when_no_semicolon_is_set
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier issue: prettier/prettier#14040
Only property signatures would conflict with the following signatures in some situations, so return early if the current signature is not a property when
no-semiis set.