test(linter/plugins): conformance tester allow filter array#16692
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 10, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Member
Author
Merge activity
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the conformance tester's filtering capabilities by allowing filter values to be either a single string or an array of strings, making it easier to debug multiple specific test cases or rules simultaneously.
Key changes:
- Modified filter type definition to accept
string | string[]instead of juststring - Updated filtering logic in both
run.tsandrule_tester.tsto handle array-based filtering using.includes()
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
apps/oxlint/conformance/src/filter.ts |
Updated type definition to allow Filter to be either a single string or an array of strings |
apps/oxlint/conformance/src/run.ts |
Modified rule name filtering logic to check if filter is an array and use .includes() for membership testing |
apps/oxlint/conformance/src/rule_tester.ts |
Modified test code filtering logic to check if filter is an array and use .includes() for membership testing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
#16659 added filtering to the conformance tester. Make the filters more flexible by accepting an array of strings, as well as a single string.
graphite-app
bot
force-pushed
the
12-10-test_linter_plugins_conformance_tester_allow_filter_array
branch
from
6b2f8af to
5d4e654
Compare
graphite-app
bot
deleted the
12-10-test_linter_plugins_conformance_tester_allow_filter_array
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
#16659 added filtering to the conformance tester. Make the filters more flexible by accepting an array of strings, as well as a single string.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ect#16692) oxc-project#16659 added filtering to the conformance tester. Make the filters more flexible by accepting an array of strings, as well as a single string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16659 added filtering to the conformance tester. Make the filters more flexible by accepting an array of strings, as well as a single string.