feat(linter/plugins): support parserOptions.ecmaFeatures.jsx option in RuleTester#16690
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 10, 2025
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 10, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the parserOptions.ecmaFeatures.jsx option to RuleTester, improving compatibility with ESLint's RuleTester API. When set to true and no explicit lang option is provided, JSX parsing is enabled automatically. This enhancement allows ~250 additional conformance tests to pass.
Key changes:
- Implemented deep merging for
ecmaFeatureswithinparserOptionsconfiguration hierarchy - Added logic to derive parse language from
ecmaFeatures.jsxwhenlangis not explicitly specified - Removed completed "TODO: Merge deeply" comments now that deep merging is implemented
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
apps/oxlint/src-js/package/rule_tester.ts |
Adds mergeEcmaFeatures function for deep config merging, updates getParseOptions to use ecmaFeatures.jsx as fallback when lang is not set, removes resolved TODO comments, and documents precedence rules |
apps/oxlint/test/rule_tester.test.ts |
Comprehensive test suite covering default behavior, explicit true/false settings, global/instance/test-case-level configuration, override scenarios, and precedence rules with the lang option |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
… in `RuleTester` (#16690) Add `parserOptions.ecmaFeatures.jsx` to `RuleTester`, for compatibility with ESLint's `RuleTester`. ```js const tester = new RuleTester({ languageOptions: { parserOptions: { ecmaFeatures: { jsx: true }, }, }, }); tester.run("my-rule", rule, { valid: [ // No parsing error "<div />", ], invalid: [], }); ``` This fixes another ~250 conformance tests.
graphite-app
bot
force-pushed
the
12-10-test_linter_plugins_shorten_ruletester_test_cases
branch
from
affb872 to
cd78a76
Compare
graphite-app
bot
force-pushed
the
12-10-feat_linter_plugins_support_parseroptions.ecmafeatures.jsx_option_in_ruletester_
branch
from
1c4f36d to
2b73b14
Compare
Base automatically changed from
12-10-test_linter_plugins_shorten_ruletester_test_cases
to
main
December 10, 2025 11:17
graphite-app
bot
deleted the
12-10-feat_linter_plugins_support_parseroptions.ecmafeatures.jsx_option_in_ruletester_
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
… in `RuleTester` (#16690) Add `parserOptions.ecmaFeatures.jsx` to `RuleTester`, for compatibility with ESLint's `RuleTester`. ```js const tester = new RuleTester({ languageOptions: { parserOptions: { ecmaFeatures: { jsx: true }, }, }, }); tester.run("my-rule", rule, { valid: [ // No parsing error "<div />", ], invalid: [], }); ``` This fixes another ~250 conformance tests.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
… in `RuleTester` (oxc-project#16690) Add `parserOptions.ecmaFeatures.jsx` to `RuleTester`, for compatibility with ESLint's `RuleTester`. ```js const tester = new RuleTester({ languageOptions: { parserOptions: { ecmaFeatures: { jsx: true }, }, }, }); tester.run("my-rule", rule, { valid: [ // No parsing error "<div />", ], invalid: [], }); ``` This fixes another ~250 conformance tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
parserOptions.ecmaFeatures.jsxtoRuleTester, for compatibility with ESLint'sRuleTester.This fixes another ~250 conformance tests.