test(linter/plugins): shorten RuleTester test cases#16689
test(linter/plugins): shorten RuleTester test cases#16689graphite-app[bot] merged 1 commit intomainfrom
RuleTester test cases#16689Conversation
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR refactors RuleTester tests by removing an outdated TODO comment and simplifying test case definitions. The config section already has adequate test coverage with 3 tests (global config, reset, and immutability), making the TODO comment obsolete. The test case simplifications convert object notation { code: "..." } to the more concise string shorthand "..." where no additional configuration is needed, following a pattern commonly used throughout the test file.
Key Changes
- Removed TODO comment for "add more config tests" as the config section has sufficient coverage
- Simplified two test cases from object form to string shorthand in "mixed across test cases" tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
Pure refactor of tests. Just shorten a couple of test cases. Also remove a TODO comment for "add more config tests". There are plenty now!
graphite-app
bot
force-pushed
the
12-10-feat_linter_plugins_add_parseroptions.lang_option_to_ruletester_
branch
from
fadb424 to
563eab7
Compare
graphite-app
bot
force-pushed
the
12-10-test_linter_plugins_shorten_ruletester_test_cases
branch
from
affb872 to
cd78a76
Compare
graphite-app
bot
deleted the
12-10-test_linter_plugins_shorten_ruletester_test_cases
branch
Pure refactor of tests. Just shorten a couple of test cases. Also remove a TODO comment for "add more config tests". There are plenty now!
Pure refactor of tests. Just shorten a couple of test cases.
Also remove a TODO comment for "add more config tests". There are plenty now!