docs(linter): Added in the missing jest rules that are compatible with vitest.#16679
Merged
camc314 merged 2 commits intooxc-project:mainfrom Dec 10, 2025
Merged
Conversation
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #16679 will not alter performanceComparing Summary
Footnotes
|
Afsoon
changed the title
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
…h vitest. (#16679) After the review @connorshea did in #16540 (review), suggested to me add a missing part of documentation in the linter rule. I hadn't added it because the reference rule I used lack of it. So this PR aims to add it in all jest rules stated as compatible. ## Before this PR The following Jest linter only had this documentation part: - consistent-test-it - expect-expect - no-alias-methods - no-commented-out-tests - no-disabled-tests - no-focused-tests - no-identical-title - no-test-prefixes - prefer-hooks-in-order - valid-describe-callback - valid-expect ## Adding in this PR - max-expects - max-nested-describe - no-conditional-expect - no-conditional-in-test - no-duplicate-hooks - no-hooks - no-interpolation-in-snapshots - no-restricted-jest-methods: I have doubts here see my comment in the [vitest-eslint-plugin issue](#4656 (comment)) - no-restricted-matchers - no-standalone-expect - no-test-return-statement - prefer-comparison-matcher - prefer-each - prefer-equality-matcher - prefer-expect-resolves - prefer-hooks-on-top - prefer-lowercase-title - prefer-mock-promise-shorthand - prefer-strict-equal - prefer-to-be - prefer-to-have-length - prefer-todo - require-to-throw-message - require-top-level-describe
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…h vitest. (oxc-project#16679) After the review @connorshea did in oxc-project#16540 (review), suggested to me add a missing part of documentation in the linter rule. I hadn't added it because the reference rule I used lack of it. So this PR aims to add it in all jest rules stated as compatible. ## Before this PR The following Jest linter only had this documentation part: - consistent-test-it - expect-expect - no-alias-methods - no-commented-out-tests - no-disabled-tests - no-focused-tests - no-identical-title - no-test-prefixes - prefer-hooks-in-order - valid-describe-callback - valid-expect ## Adding in this PR - max-expects - max-nested-describe - no-conditional-expect - no-conditional-in-test - no-duplicate-hooks - no-hooks - no-interpolation-in-snapshots - no-restricted-jest-methods: I have doubts here see my comment in the [vitest-eslint-plugin issue](oxc-project#4656 (comment)) - no-restricted-matchers - no-standalone-expect - no-test-return-statement - prefer-comparison-matcher - prefer-each - prefer-equality-matcher - prefer-expect-resolves - prefer-hooks-on-top - prefer-lowercase-title - prefer-mock-promise-shorthand - prefer-strict-equal - prefer-to-be - prefer-to-have-length - prefer-todo - require-to-throw-message - require-top-level-describe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the review @connorshea did in #16540 (review), suggested to me add a missing part of documentation in the linter rule. I hadn't added it because the reference rule I used lack of it.
So this PR aims to add it in all jest rules stated as compatible.
Before this PR
The following Jest linter only had this documentation part:
Adding in this PR