Skip to content

test(linter/plugins): add 1 more test case for sourceType in RuleTester#16671

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-09-test_linter_plugins_add_1_more_test_case_for_sourcetype_in_ruletester_
Dec 10, 2025
Merged

test(linter/plugins): add 1 more test case for sourceType in RuleTester#16671
graphite-app[bot] merged 1 commit intomainfrom
12-09-test_linter_plugins_add_1_more_test_case_for_sourcetype_in_ruletester_

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Dec 9, 2025 •
edited
Loading

Follow-on after #16660. Add 1 more test that I missed in #16670.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Dec 9, 2025
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Dec 9, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2025 23:43
Copilot AI review requested due to automatic review settings December 9, 2025 23:43
@overlookmotel overlookmotel self-assigned this Dec 9, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Dec 9, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel overlookmotel removed the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
@overlookmotel overlookmotel marked this pull request as draft December 9, 2025 23:45
@overlookmotel overlookmotel mentioned this pull request Dec 9, 2025
Merged
Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a missing test case to verify the default sourceType behavior in RuleTester. The test ensures that when no sourceType is explicitly specified, the parser defaults to "module" mode, which causes with statements to fail parsing (as expected). This is a follow-on to PR #16660 and adds test coverage that was missed in PR #16670.

Key Changes:

  • Added test case for default sourceType behavior (no explicit configuration)
  • Updated snapshot to include expected parsing error for the new test case

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
@overlookmotel overlookmotel marked this pull request as ready for review December 9, 2025 23:54
@overlookmotel
test(linter/plugins): add 1 more test case for sourceType in `RuleT…
388030c 
…ester` (#16671)

Follow-on after #16660. Add 1 more test that I missed in #16670.
@graphite-app graphite-app bot force-pushed the 12-09-test_linter_plugins_add_1_more_test_case_for_sourcetype_in_ruletester_ branch from 4b347c9 to 388030c Compare December 9, 2025 23:54
@graphite-app graphite-app bot merged commit 388030c into main Dec 10, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 12-09-test_linter_plugins_add_1_more_test_case_for_sourcetype_in_ruletester_ branch December 10, 2025 00:01
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 10, 2025
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
@overlookmotel
test(linter/plugins): add 1 more test case for sourceType in `RuleT…
bf94076 
…ester` (#16671)

Follow-on after #16660. Add 1 more test that I missed in #16670.
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@overlookmotel @taearls
test(linter/plugins): add 1 more test case for sourceType in `RuleT…
dabacdb 
…ester` (oxc-project#16671)

Follow-on after oxc-project#16660. Add 1 more test that I missed in oxc-project#16670.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel