test(linter/plugins): simplify enabling ESLint compat mode in conformance tester#16658
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 9, 2025
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-test
This was referenced Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the conformance tester's setup for enabling ESLint compatibility mode by introducing a debug-only hook mechanism. Previously, the conformance tester used a complex system of overriding RuleTester methods to prevent disabling eslintCompat. Now, it uses a simpler hook-based approach that modifies test cases just before they're executed.
Key changes:
- Added
registerModifyTestCaseHookmethod toRuleTester(debug builds only) for registering callbacks that modify test cases before execution - Modified
mergeConfigIntoTestCaseto invoke the registered hook on the merged test case configuration - Simplified conformance tester's
RuleTesterShimby removing complex config protection logic and using the hook to seteslintCompat: truedirectly on test cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
apps/oxlint/src-js/package/rule_tester.ts |
Adds debug-only registerModifyTestCaseHook API and calls registered hook in mergeConfigIntoTestCase before returning merged test case |
apps/oxlint/conformance/src/rule_tester.ts |
Removes complex config protection logic and uses new hook mechanism to set eslintCompat: true on test cases; removes unused assert import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
Merge activity
|
…ance tester (#16658) Conformance test runner had a complicated set-up to inject `eslintCompat: true` to the options for running rules. Simplify this by: * Adding an undocumented `registerModifyTestCaseHook` method to `RuleTester` which is only present in debug build. * Using that hook to set `eslintCompat: true` just before the test case is run. This change also enables more complicated modifications of test cases to come in later PRs, to e.g. enable handling test cases which are TypeScript.
graphite-app
bot
force-pushed
the
12-09-refactor_linter_plugins_refactor_config_merging_in_ruletester_
branch
from
18e615d to
eb9f814
Compare
graphite-app
bot
force-pushed
the
12-09-test_linter_plugins_simplify_enabling_eslint_compat_mode_in_conformance_tester
branch
from
1e9ae6a to
f791273
Compare
Base automatically changed from
12-09-refactor_linter_plugins_refactor_config_merging_in_ruletester_
to
main
December 9, 2025 18:50
graphite-app
bot
deleted the
12-09-test_linter_plugins_simplify_enabling_eslint_compat_mode_in_conformance_tester
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
…ance tester (#16658) Conformance test runner had a complicated set-up to inject `eslintCompat: true` to the options for running rules. Simplify this by: * Adding an undocumented `registerModifyTestCaseHook` method to `RuleTester` which is only present in debug build. * Using that hook to set `eslintCompat: true` just before the test case is run. This change also enables more complicated modifications of test cases to come in later PRs, to e.g. enable handling test cases which are TypeScript.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ance tester (oxc-project#16658) Conformance test runner had a complicated set-up to inject `eslintCompat: true` to the options for running rules. Simplify this by: * Adding an undocumented `registerModifyTestCaseHook` method to `RuleTester` which is only present in debug build. * Using that hook to set `eslintCompat: true` just before the test case is run. This change also enables more complicated modifications of test cases to come in later PRs, to e.g. enable handling test cases which are TypeScript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conformance test runner had a complicated set-up to inject
eslintCompat: trueto the options for running rules.Simplify this by:
registerModifyTestCaseHookmethod toRuleTesterwhich is only present in debug build.eslintCompat: truejust before the test case is run.This change also enables more complicated modifications of test cases to come in later PRs, to e.g. enable handling test cases which are TypeScript.