refactor(linter/plugins): refactor config merging in RuleTester#16657
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 9, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 9, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors config merging in RuleTester to simplify the handling of three-level configuration (default, instance, and test case). Instead of passing config separately through multiple function layers, configs are now merged directly into each test case object at the start of test execution, making the data flow more straightforward.
Key Changes:
- Removed index signature
[key: string]: unknownfromConfiginterface for stricter typing - Made
TestCaseinterface extendConfigto allow test cases to have config properties - Refactored config merging to happen once per test case via
mergeConfigIntoTestCase()instead of repeatedly through function chains - Added
TEST_CASE_PROP_KEYSset to filter test-case-specific properties during config merging, including"__proto__"for security
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/oxlint/test/rule_tester.test.ts | Updated tests to use actual config property eslintCompat instead of arbitrary whatever property, reflecting stricter Config interface typing |
| apps/oxlint/src-js/package/rule_tester.ts | Core refactoring: removed index signature from Config, added config filtering logic, merged config into test cases early in execution flow, updated function signatures accordingly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
…6657) `RuleTester` has 3 levels of config: 1. Default config - set with `RuleTester.setDefaultConfig(...)`. 2. `RuleTester` instance config - set with `new RuleTester(...)`. 3. Config set on individual test cases. Simplify handling all this by merging configs into each `TestCase`, so that `TestCase` contains all the properties for an individual test - regardless of at what level they were set.
graphite-app
bot
force-pushed
the
12-09-refactor_linter_plugins_refactor_config_merging_in_ruletester_
branch
from
18e615d to
eb9f814
Compare
graphite-app
bot
deleted the
12-09-refactor_linter_plugins_refactor_config_merging_in_ruletester_
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
…6657) `RuleTester` has 3 levels of config: 1. Default config - set with `RuleTester.setDefaultConfig(...)`. 2. `RuleTester` instance config - set with `new RuleTester(...)`. 3. Config set on individual test cases. Simplify handling all this by merging configs into each `TestCase`, so that `TestCase` contains all the properties for an individual test - regardless of at what level they were set.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…c-project#16657) `RuleTester` has 3 levels of config: 1. Default config - set with `RuleTester.setDefaultConfig(...)`. 2. `RuleTester` instance config - set with `new RuleTester(...)`. 3. Config set on individual test cases. Simplify handling all this by merging configs into each `TestCase`, so that `TestCase` contains all the properties for an individual test - regardless of at what level they were set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RuleTesterhas 3 levels of config:RuleTester.setDefaultConfig(...).RuleTesterinstance config - set withnew RuleTester(...).Simplify handling all this by merging configs into each
TestCase, so thatTestCasecontains all the properties for an individual test - regardless of at what level they were set.