perf(oxlint): run e2e tests concurrently#16651
Conversation
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
force-pushed
the
c/12-09-perf_oxlint_run_e2e_tests_concurrently
branch
from
abf165b to
96408fe
Compare
There was a problem hiding this comment.
Pull request overview
This PR optimizes test execution time by enabling concurrent test runs for oxlint's e2e tests. The changes thread Vitest's expect function from the test context through utility functions to ensure proper test isolation when running tests concurrently.
- Modified test utilities to accept an optional
expectparameter with a sensible default - Updated e2e tests to use
describe.concurrentandit.concurrentfor parallel execution - Properly threaded the
expectfunction from test context to maintain test isolation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxlint/test/utils.ts | Added optional expect parameter to testFixtureWithCommand to support concurrent test execution |
| apps/oxlint/test/e2e.test.ts | Enabled concurrent test execution and threaded expect from test context to utilities |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camchenry
left a comment
camchenry
left a comment
There was a problem hiding this comment.
Makes sense to run concurrently with all of the async file/cmd operation here.
Merge activity
|
Tests in the same file typically run in sequence. we can improve the performance by running these in parallel: https://vitest.dev/guide/parallelism.html#test-parallelism - Before (sequential): ~5.2s total, e2e.test.ts ~5000ms - After (concurrent): ~1.50s total, e2e.test.ts ~1200ms ~3.5x faster
graphite-app
bot
force-pushed
the
c/12-09-perf_oxlint_run_e2e_tests_concurrently
branch
from
96408fe to
a5dc4c6
Compare
graphite-app
bot
deleted the
c/12-09-perf_oxlint_run_e2e_tests_concurrently
branch
|
Nice! |
Tests in the same file typically run in sequence. we can improve the performance by running these in parallel:
https://vitest.dev/guide/parallelism.html#test-parallelism
~3.5x faster