Skip to content

docs(linter): update no-unsafe-type-assertion to reflect correct rule behavior#16646

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-09-docs_linter_update_no-unsafe-type-assertion_to_reflect_correct_rule_behavior
Dec 9, 2025
Merged

docs(linter): update no-unsafe-type-assertion to reflect correct rule behavior#16646
graphite-app[bot] merged 1 commit intomainfrom
c/12-09-docs_linter_update_no-unsafe-type-assertion_to_reflect_correct_rule_behavior

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Dec 9, 2025

@camc314 camc314 marked this pull request as ready for review December 9, 2025 12:20
Copilot AI review requested due to automatic review settings December 9, 2025 12:20
@github-actions github-actions bot added the A-linter Area - Linter label Dec 9, 2025
@camc314 camc314 self-assigned this Dec 9, 2025
@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Dec 9, 2025
@camc314 Graphite App
Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 9, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the documentation for the no-unsafe-type-assertion TypeScript linter rule to accurately reflect its intended behavior. The previous documentation incorrectly described the rule as disallowing type assertions using any, but the rule actually disallows type assertions that narrow types (which can bypass TypeScript's type-checking).

Key Changes

  • Updated rule description to focus on type narrowing rather than any types
  • Replaced all code examples to demonstrate narrowing vs. broadening type assertions
  • Clarified that broadening type assertions are safe while narrowing ones are unsafe

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16646 will not alter performance

Comparing c/12-09-docs_linter_update_no-unsafe-type-assertion_to_reflect_correct_rule_behavior (dc793ad) with main (6cddbe7)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on main (dc793ad) during the generation of this report, so 6cddbe7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Dec 9, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/12-09-docs_linter_update_no-unsafe-type-assertion_to_reflect_correct_rule_behavior branch from 24933d5 to dc793ad Compare December 9, 2025 12:26
@graphite-app graphite-app bot merged commit dc793ad into main Dec 9, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-09-docs_linter_update_no-unsafe-type-assertion_to_reflect_correct_rule_behavior branch December 9, 2025 12:30
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
@camc314
docs(linter): update no-unsafe-type-assertion to reflect correct rule…
486813a 
… behavior (#16646)

Fixes oxc-project/tsgolint#492
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@camc314 @taearls
docs(linter): update no-unsafe-type-assertion to reflect correct rule…
c8f8ce5 
… behavior (oxc-project#16646)

Fixes oxc-project/tsgolint#492
@Boshen Boshen mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Documentation] no-unsafe-type-assertion is documented to be much less powerful than the typescript-eslint rule

2 participants

@camc314