feat(linter/plugins): RuleTester parser support options#16641
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 9, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds parser options support to RuleTester by introducing a ParserOptions struct that allows configuring the language type (js, jsx, ts, tsx, dts) and source type (script, module, unambiguous) for parsing. The options are threaded through from TypeScript to Rust and used to configure the parser's SourceType.
Key Changes:
- Added
ParserOptionsstruct withlangandsource_typefields on Rust side - Updated
parse_raw_syncandparse_raw_implto accept optional parser options - Added corresponding TypeScript type definitions and updated the
parsefunction signature
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
apps/oxlint/src/js_plugins/parse.rs |
Adds ParserOptions struct, updates parser functions to accept options, and includes get_source_type helper function to process the options |
apps/oxlint/src-js/package/parse.ts |
Updates parse function signature to accept optional ParseOptions parameter and passes it to Rust binding |
apps/oxlint/src-js/bindings.d.ts |
Defines ParserOptions TypeScript interface and updates parseRawSync signature (auto-generated) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
12-08-feat_linter_plugins_ruletester_parser_support_options
branch
from
fdabc71 to
d5bf26a
Compare
CodSpeed Performance ReportMerging #16641 will not alter performanceComparing Summary
Footnotes
|
overlookmotel
force-pushed
the
12-08-feat_linter_plugins_ruletester_parser_support_options
branch
from
d5bf26a to
fbdd54f
Compare
Contributor
Merge activity
|
Add options to the parser used in `RuleTester`. Currently `RuleTester` doesn't actually use these options, but this prepares the way for other changes to `RuleTester` in future PRs. The extra types for `Comment` etc in `bindings.d.ts` are just the result of using `oxc_napi` crate for its `get_source_type` function. We don't use those types, but they're also not exposed externally, so it doesn't matter.
graphite-app
bot
force-pushed
the
12-08-feat_linter_plugins_ruletester_parser_support_options
branch
from
fbdd54f to
554250e
Compare
graphite-app
bot
deleted the
12-08-feat_linter_plugins_ruletester_parser_support_options
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
Add options to the parser used in `RuleTester`. Currently `RuleTester` doesn't actually use these options, but this prepares the way for other changes to `RuleTester` in future PRs. The extra types for `Comment` etc in `bindings.d.ts` are just the result of using `oxc_napi` crate for its `get_source_type` function. We don't use those types, but they're also not exposed externally, so it doesn't matter.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…t#16641) Add options to the parser used in `RuleTester`. Currently `RuleTester` doesn't actually use these options, but this prepares the way for other changes to `RuleTester` in future PRs. The extra types for `Comment` etc in `bindings.d.ts` are just the result of using `oxc_napi` crate for its `get_source_type` function. We don't use those types, but they're also not exposed externally, so it doesn't matter.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…fig types (oxc-project#16642) Add to types for `Config` and `TestCase` in `RuleTester`. Similar to oxc-project#16641, these options are currently ignored, but it prepares the way for other changes to `RuleTester` in future PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add options to the parser used in
RuleTester. CurrentlyRuleTesterdoesn't actually use these options, but this prepares the way for other changes toRuleTesterin future PRs.The extra types for
Commentetc inbindings.d.tsare just the result of usingoxc_napicrate for itsget_source_typefunction. We don't use those types, but they're also not exposed externally, so it doesn't matter.