perf(formatter): optimize formatting of JSX element/fragment with a single child#16631
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 9, 2025
Conversation
github-actions
bot
added
A-formatter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #16631 will not alter performanceComparing Summary
Footnotes
|
Dunqing
force-pushed
the
12-09-perf_formatter_do_not_write_elements_to_the_flat_buffer_if_the_layout_is_multline
branch
from
8d58f68 to
c17b3d4
Compare
Dunqing
force-pushed
the
12-09-perf_formatter_optimize_formatting_of_jsx_element_fragment_with_a_single_child
branch
2 times, most recently
from
53474e3 to
e739576
Compare
Dunqing
force-pushed
the
12-09-perf_formatter_do_not_write_elements_to_the_flat_buffer_if_the_layout_is_multline
branch
from
c17b3d4 to
02172b8
Compare
Dunqing
force-pushed
the
12-09-perf_formatter_optimize_formatting_of_jsx_element_fragment_with_a_single_child
branch
from
e739576 to
64adcd2
Compare
Dunqing
force-pushed
the
12-09-perf_formatter_do_not_write_elements_to_the_flat_buffer_if_the_layout_is_multline
branch
from
02172b8 to
b3581c8
Compare
Dunqing
force-pushed
the
12-09-perf_formatter_optimize_formatting_of_jsx_element_fragment_with_a_single_child
branch
2 times, most recently
from
6515f47 to
bc98c23
Compare
Member
Merge activity
|
leaysgur
approved these changes
Dec 9, 2025
…ingle child (#16631) Add `FormatSingleChild` for optimizing JSX elements/fragments with a single meaningful child. When there is only a single child, we do not need to write the child into a temporary buffer and then take it when formatting. Instead, we can directly write the child into the root buffer. Also, this can avoid calling costly `best_fitting!` formatting in some situations.
graphite-app
bot
force-pushed
the
12-09-perf_formatter_do_not_write_elements_to_the_flat_buffer_if_the_layout_is_multline
branch
from
b3581c8 to
4843475
Compare
graphite-app
bot
force-pushed
the
12-09-perf_formatter_optimize_formatting_of_jsx_element_fragment_with_a_single_child
branch
from
bc98c23 to
c7db70b
Compare
Base automatically changed from
12-09-perf_formatter_do_not_write_elements_to_the_flat_buffer_if_the_layout_is_multline
to
main
December 9, 2025 09:12
graphite-app
bot
deleted the
12-09-perf_formatter_optimize_formatting_of_jsx_element_fragment_with_a_single_child
branch
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
…ingle child (#16631) Add `FormatSingleChild` for optimizing JSX elements/fragments with a single meaningful child. When there is only a single child, we do not need to write the child into a temporary buffer and then take it when formatting. Instead, we can directly write the child into the root buffer. Also, this can avoid calling costly `best_fitting!` formatting in some situations.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ingle child (oxc-project#16631) Add `FormatSingleChild` for optimizing JSX elements/fragments with a single meaningful child. When there is only a single child, we do not need to write the child into a temporary buffer and then take it when formatting. Instead, we can directly write the child into the root buffer. Also, this can avoid calling costly `best_fitting!` formatting in some situations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
FormatSingleChildfor optimizing JSX elements/fragments with a single meaningful child.When there is only a single child, we do not need to write the child into a temporary buffer and then take it when formatting. Instead, we can directly write the child into the root buffer.
Also, this can avoid calling costly
best_fitting!formatting in some situations.