Skip to content

feat(oxfmt): trace which files are being formatted via OXC_LOG=debug#16627

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-09-feat_oxfmt_trace_which_files_are_being_formatted_via_oxc_log_debug_
Dec 9, 2025
Merged

feat(oxfmt): trace which files are being formatted via OXC_LOG=debug#16627
graphite-app[bot] merged 1 commit intomainfrom
12-09-feat_oxfmt_trace_which_files_are_being_formatted_via_oxc_log_debug_

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Dec 9, 2025

closes #16607

Copilot AI review requested due to automatic review settings December 9, 2025 03:33
@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request labels Dec 9, 2025
Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds debug-level tracing to show which files are being formatted when using OXC_LOG=debug environment variable. The change enables users to monitor formatting progress and troubleshoot issues by seeing exactly which files are being processed.

  • Adds tracing crate dependency to the workspace and oxfmt
  • Inserts a debug log statement before formatting each file
  • Updates tracing and related crate versions in Cargo.lock

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
apps/oxfmt/src/cli/service.rs Adds debug log statement to trace file formatting with relative path display
apps/oxfmt/Cargo.toml Adds tracing crate dependency from workspace
Cargo.toml Defines tracing version 0.1.43 in workspace dependencies
Cargo.lock Updates tracing, tracing-attributes, and tracing-core to latest patch versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #16627 will degrade performances by 3.06%

Comparing 12-09-feat_oxfmt_trace_which_files_are_being_formatted_via_oxc_log_debug_ (92fc10a) with main (14d803a)

Summary

❌ 1 regression
✅ 41 untouched
⏩ 3 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
❌ Simulation minifier[cal.com.tsx] 36.1 ms 37.2 ms -3.06%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
@leaysgur Graphite App
Copy link
Copy Markdown
Member

leaysgur commented Dec 9, 2025 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 12-09-feat_oxfmt_trace_which_files_are_being_formatted_via_oxc_log_debug_ branch from 92fc10a to feffe48 Compare December 9, 2025 04:04
@graphite-app graphite-app bot merged commit feffe48 into main Dec 9, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-09-feat_oxfmt_trace_which_files_are_being_formatted_via_oxc_log_debug_ branch December 9, 2025 04:10
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 9, 2025
@leaysgur leaysgur mentioned this pull request Dec 9, 2025
Closed
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
@Boshen
feat(oxfmt): trace which files are being formatted via OXC_LOG=debug (
69dafd8 
#16627)

closes #16607
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@Boshen @taearls
feat(oxfmt): trace which files are being formatted via OXC_LOG=debug (
d09873e 
oxc-project#16627)

closes oxc-project#16607
@Boshen Boshen mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@leaysgur leaysgur

Labels

A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

oxfmt: add tracing

3 participants

@Boshen @leaysgur