feat(linter): add unicorn/prefer-keyboard-event-key rule#16611
Merged
camc314 merged 3 commits intooxc-project:mainfrom Dec 10, 2025
Merged
feat(linter): add unicorn/prefer-keyboard-event-key rule#16611camc314 merged 3 commits intooxc-project:mainfrom
camc314 merged 3 commits intooxc-project:mainfrom
Conversation
github-actions
bot
added
A-linter
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the unicorn/prefer-keyboard-event-key linter rule, which enforces the use of the modern KeyboardEvent.key property over the deprecated keyCode, charCode, and which properties. The rule includes auto-fix capabilities that can automatically replace deprecated property accesses with the appropriate key comparisons when used in binary expressions.
Key Changes
- Adds comprehensive rule implementation with support for detecting deprecated properties in direct property access and destructuring patterns
- Implements auto-fix functionality that converts numeric key code comparisons to string key comparisons
- Includes extensive test coverage with 47 failing cases and 20 fix test cases
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/oxc_linter/src/rules/unicorn/prefer_keyboard_event_key.rs |
Complete rule implementation with detection logic, auto-fix, and comprehensive test suite |
crates/oxc_linter/src/rules.rs |
Registers the new rule in the linter's rule registry |
crates/oxc_linter/src/snapshots/unicorn_prefer_keyboard_event_key.snap |
Test snapshot containing expected diagnostic outputs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crates/oxc_linter/src/rules/unicorn/prefer_keyboard_event_key.rs
Outdated
Show resolved
Hide resolved
crates/oxc_linter/src/rules/unicorn/prefer_keyboard_event_key.rs
Outdated
Show resolved
Hide resolved
CodSpeed Performance ReportMerging #16611 will not alter performanceComparing Summary
Footnotes
|
re-taro
force-pushed
the
feat/prefer-keyboard-event-key
branch
from
6e1e4a1 to
438f8b2
Compare
connorshea
reviewed
Dec 9, 2025
crates/oxc_linter/src/rules/unicorn/prefer_keyboard_event_key.rs
Outdated
Show resolved
Hide resolved
connorshea
reviewed
Dec 9, 2025
crates/oxc_linter/src/rules/unicorn/prefer_keyboard_event_key.rs
Outdated
Show resolved
Hide resolved
camc314
requested changes
Dec 9, 2025
Contributor
camc314
left a comment
camc314
left a comment
There was a problem hiding this comment.
Thanks for working on this! Unfortunately it looks like CI is failing as not all the test cases are passing
camc314
force-pushed
the
feat/prefer-keyboard-event-key
branch
from
59bb678 to
7c241e0
Compare
Copilot AI
pushed a commit
that referenced
this pull request
Dec 10, 2025
This PR adds unicorn/prefer-keyboard-event-key rule, issue #684 [rule doc](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/prefer-keyboard-event-key.md) [rule source](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/rules/prefer-keyboard-event-key.js) --------- Co-authored-by: Cameron Clark <[email protected]>
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…#16611) This PR adds unicorn/prefer-keyboard-event-key rule, issue oxc-project#684 [rule doc](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/docs/rules/prefer-keyboard-event-key.md) [rule source](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/v62.0.0/rules/prefer-keyboard-event-key.js) --------- Co-authored-by: Cameron Clark <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unicorn/prefer-keyboard-event-key rule, issue #684
rule doc
rule source