Skip to content

feat(linter): promote no_map_spread rule from nursery to perf#16604

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-08-feat_linter_promote_no_map_spread_rule_from_nursery_to_perf
Dec 8, 2025
Merged

feat(linter): promote no_map_spread rule from nursery to perf#16604
graphite-app[bot] merged 1 commit intomainfrom
c/12-08-feat_linter_promote_no_map_spread_rule_from_nursery_to_perf

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Dec 8, 2025 •
edited
Loading

This rule has been in nursery for 13 months, we have (hopefully) fixed all issues relating to it, so it should be ready to promote to performance

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 8, 2025
@camc314 Graphite App
Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 8, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review December 8, 2025 12:40
Copilot AI review requested due to automatic review settings December 8, 2025 12:40
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
@camc314 camc314 self-assigned this Dec 8, 2025
@camc314 camc314 mentioned this pull request Dec 8, 2025
Merged
@camc314 Graphite App
Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 8, 2025 •
edited by graphite-app bot
Loading

Merge activity

Copilot AI reviewed Dec 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR promotes the no_map_spread linter rule from the nursery category to the performance category after 13 months of testing and stabilization. This rule identifies inefficient use of object and array spreads in map and flatMap calls.

  • Updates the rule category from nursery to perf in the declare_oxc_lint! macro
  • Removes the TODO comment about battle-testing the rule

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 8, 2025

CodSpeed Performance Report

Merging #16604 will not alter performance

Comparing c/12-08-feat_linter_promote_no_map_spread_rule_from_nursery_to_perf (eac240c) with main (75d489a)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on main (6b019ce) during the generation of this report, so 75d489a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314
feat(linter): promote no_map_spread rule from nursery to perf (#16604)
7c7219e 
This rule has been in nursery for 13 months, we have (hopefully) fixed all issues relating to it, so it should be ready to promote to performance
@graphite-app graphite-app bot force-pushed the c/12-08-feat_linter_promote_no_map_spread_rule_from_nursery_to_perf branch from eac240c to 7c7219e Compare December 8, 2025 12:45
@graphite-app graphite-app bot merged commit 7c7219e into main Dec 8, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-08-feat_linter_promote_no_map_spread_rule_from_nursery_to_perf branch December 8, 2025 12:50
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 8, 2025
Copilot AI pushed a commit that referenced this pull request Dec 10, 2025
@camc314
feat(linter): promote no_map_spread rule from nursery to perf (#16604)
c0a5f2d 
This rule has been in nursery for 13 months, we have (hopefully) fixed all issues relating to it, so it should be ready to promote to performance
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@camc314 @taearls
feat(linter): promote no_map_spread rule from nursery to perf (oxc-pr…
1e91ff4 
…oject#16604)

This rule has been in nursery for 13 months, we have (hopefully) fixed all issues relating to it, so it should be ready to promote to performance
@Boshen Boshen mentioned this pull request Dec 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314