ci(lint): use prefer-const rule from ESLint#16448
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 3, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
11-26-ci_lint_use_prefer-const_rule_from_eslint
branch
from
3f1df29 to
6a4af9a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables ESLint's prefer-const rule as a JavaScript plugin in Oxlint to dogfood the JS plugin functionality while awaiting native implementation in issue #15707. The change adds ESLint as a dependency and creates a custom plugin that wraps ESLint's built-in rules for use within Oxlint.
Key changes:
- Adds ESLint 9.39.1 as a development dependency for accessing built-in ESLint rules
- Creates a new JS plugin (
oxlint-plugin.mts) that exports ESLint'sprefer-construle - Configures Oxlint to use the JS plugin and enables the
prefer-construle with "all" destructuring mode
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adds ESLint ^9.39.1 as a devDependency |
| pnpm-lock.yaml | Updates lock file with ESLint 9.39.1 and its dependencies |
| oxlintrc.json | Adds jsPlugins configuration and enables eslint-js/prefer-const rule |
| oxlint-plugin.mts | New JS plugin that wraps ESLint's built-in rules for use in Oxlint |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graphite-app
bot
changed the base branch from
12-03-perf_napi_parser_do_not_remove_extraneous_options_on_js_side
to
graphite-base/16448
graphite-app
bot
force-pushed
the
graphite-base/16448
branch
from
98c53a9 to
790beeb
Compare
graphite-app
bot
force-pushed
the
11-26-ci_lint_use_prefer-const_rule_from_eslint
branch
from
6a4af9a to
075113a
Compare
graphite-app
bot
force-pushed
the
11-26-ci_lint_use_prefer-const_rule_from_eslint
branch
from
075113a to
635db80
Compare
camc314
reviewed
Dec 3, 2025
camc314
reviewed
Dec 3, 2025
camc314
approved these changes
Dec 3, 2025
overlookmotel
force-pushed
the
11-26-ci_lint_use_prefer-const_rule_from_eslint
branch
from
635db80 to
5fb19d6
Compare
Member
Author
Merge activity
|
Dogfood Oxlint JS plugins by enabling ESLint's `prefer-const` rule, running as a JS plugin. #15707 will implement this rule natively in Oxlint, but in meantime this is a good one to use to test JS plugins.
graphite-app
bot
force-pushed
the
11-26-ci_lint_use_prefer-const_rule_from_eslint
branch
from
5fb19d6 to
46bd226
Compare
graphite-app
bot
deleted the
11-26-ci_lint_use_prefer-const_rule_from_eslint
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
Dogfood Oxlint JS plugins by enabling ESLint's `prefer-const` rule, running as a JS plugin. oxc-project#15707 will implement this rule natively in Oxlint, but in meantime this is a good one to use to test JS plugins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dogfood Oxlint JS plugins by enabling ESLint's
prefer-construle, running as a JS plugin.#15707 will implement this rule natively in Oxlint, but in meantime this is a good one to use to test JS plugins.