test(lsp): add simple tests for textDocument/didOpen|didChange|didClose and textDocument/codeAction#16404
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 2, 2025
Conversation
github-actions
bot
added
A-editor
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive tests for the LSP (Language Server Protocol) server's text document lifecycle notifications (textDocument/didOpen, textDocument/didChange, textDocument/didClose) and code action functionality (textDocument/codeAction). The changes include both unit-level tests in worker.rs and integration-level tests in tests.rs.
- Adds test helper functions for creating LSP requests for document lifecycle and code actions
- Implements
get_code_actions_or_commandsinFakeToolto support testing - Adds unit test
test_code_action_collectioninworker.rsto test the worker's code action collection - Adds integration tests for file notifications and code actions with and without results
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| crates/oxc_language_server/src/worker.rs | Adds import for code action types and unit test for code action collection at the worker level |
| crates/oxc_language_server/src/tests.rs | Adds test helper functions (did_open, did_change, did_close, code_action), implements get_code_actions_or_commands in FakeTool, and adds three integration tests for file notifications and code actions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
12-01-fix_lsp_respect_null_as_invalid_settings_for_workspace_didchangeconfiguration_
branch
from
b86e60b to
804144f
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
…ose` and `textDocument/codeAction` (#16404) > This PR adds comprehensive tests for the LSP (Language Server Protocol) server's text document lifecycle notifications (textDocument/didOpen, textDocument/didChange, textDocument/didClose) and code action functionality (textDocument/codeAction). The changes include both unit-level tests in worker.rs and integration-level tests in tests.rs.
graphite-app
bot
force-pushed
the
12-02-test_lsp_add_simple_tests_for_textdocument_didopen_didchange_didclose_and_textdocument_codeaction_
branch
from
efc6e01 to
ceaeb54
Compare
Base automatically changed from
12-01-fix_lsp_respect_null_as_invalid_settings_for_workspace_didchangeconfiguration_
to
main
December 2, 2025 18:26
…ose` and `textDocument/codeAction` (#16404) > This PR adds comprehensive tests for the LSP (Language Server Protocol) server's text document lifecycle notifications (textDocument/didOpen, textDocument/didChange, textDocument/didClose) and code action functionality (textDocument/codeAction). The changes include both unit-level tests in worker.rs and integration-level tests in tests.rs.
Sysix
force-pushed
the
12-02-test_lsp_add_simple_tests_for_textdocument_didopen_didchange_didclose_and_textdocument_codeaction_
branch
from
ceaeb54 to
af67e80
Compare
graphite-app
bot
deleted the
12-02-test_lsp_add_simple_tests_for_textdocument_didopen_didchange_didclose_and_textdocument_codeaction_
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ose` and `textDocument/codeAction` (oxc-project#16404) > This PR adds comprehensive tests for the LSP (Language Server Protocol) server's text document lifecycle notifications (textDocument/didOpen, textDocument/didChange, textDocument/didClose) and code action functionality (textDocument/codeAction). The changes include both unit-level tests in worker.rs and integration-level tests in tests.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.