Skip to content

Comments

refactor(linter): extract SourceTextCache to deduplicate source text lookups in tsgolint#16342

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint
Dec 1, 2025
Merged

refactor(linter): extract SourceTextCache to deduplicate source text lookups in tsgolint#16342
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 1, 2025

we're doing exactly the same thing in a bunch of places, reuse the code to make it easier to comprehend

Copy link
Contributor Author

camc314 commented Dec 1, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 1, 2025
@camc314 camc314 self-assigned this Dec 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

CodSpeed Performance Report

Merging #16342 will not alter performance

Comparing c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint (3b1c4b7) with c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics (a85b58b)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics (c160ca8) during the generation of this report, so f5f4def was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 force-pushed the c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics branch from 23c6778 to a85b58b Compare December 1, 2025 14:26
@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 5b97afd to e8f1d00 Compare December 1, 2025 14:26
@camc314 camc314 force-pushed the c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics branch from a85b58b to f2c4244 Compare December 1, 2025 15:55
@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from e8f1d00 to 94b453e Compare December 1, 2025 15:55
@camc314 camc314 force-pushed the c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics branch from f2c4244 to c160ca8 Compare December 1, 2025 15:57
@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 94b453e to 3b1c4b7 Compare December 1, 2025 15:57
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
@camc314 camc314 marked this pull request as ready for review December 1, 2025 16:02
Copy link
Contributor Author

camc314 commented Dec 1, 2025

Merge activity

@camc314 camc314 force-pushed the c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics branch from c160ca8 to 6ab5373 Compare December 1, 2025 16:04
@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 3b1c4b7 to 2ab5a55 Compare December 1, 2025 16:04
@camc314 camc314 force-pushed the c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics branch from 6ab5373 to 4f71440 Compare December 1, 2025 16:05
@camc314 camc314 force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 2ab5a55 to 5520be4 Compare December 1, 2025 16:05
…lookups in tsgolint (#16342)

we're doing exactly the same thing in a bunch of places, reuse the code to make it easier to comprehend
@graphite-app graphite-app bot force-pushed the c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics branch from 4f71440 to d846c53 Compare December 1, 2025 16:29
@graphite-app graphite-app bot force-pushed the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch from 5520be4 to 06371e2 Compare December 1, 2025 16:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
Base automatically changed from c/12-01-fix_tsgolint_use_expect_when_sending_diagnostics to main December 1, 2025 16:34
@graphite-app graphite-app bot merged commit 06371e2 into main Dec 1, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/12-01-refactor_linter_extract_sourcetextcache_to_deduplicate_source_text_lookups_in_tsgolint branch December 1, 2025 16:35
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
…lookups in tsgolint (oxc-project#16342)

we're doing exactly the same thing in a bunch of places, reuse the code to make it easier to comprehend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant