refactor(linter): store rule options as Vecs#16339
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 2, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 1, 2025
CodSpeed Performance ReportMerging #16339 will not alter performanceComparing Summary
Footnotes
|
3 tasks
graphite-app
bot
force-pushed
the
12-01-perf_linter_avoid_cloning_rule_options
branch
2 times, most recently
from
efee93a to
c39aaa5
Compare
graphite-app
bot
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
2876176 to
ec38b61
Compare
overlookmotel
changed the base branch from
12-01-perf_linter_avoid_cloning_rule_options
to
graphite-base/16339
overlookmotel
changed the base branch from
graphite-base/16339
to
12-01-perf_linter_avoid_cloning_rule_options
overlookmotel
changed the base branch from
12-01-perf_linter_avoid_cloning_rule_options
to
graphite-base/16339
overlookmotel
changed the base branch from
graphite-base/16339
to
12-01-perf_linter_avoid_cloning_rule_options
overlookmotel
changed the base branch from
12-01-perf_linter_avoid_cloning_rule_options
to
graphite-base/16339
overlookmotel
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
ec38b61 to
b77cfba
Compare
overlookmotel
force-pushed
the
graphite-base/16339
branch
from
c39aaa5 to
43b9cc1
Compare
overlookmotel
changed the base branch from
graphite-base/16339
to
12-01-fix_linter_no-magic-numbers_fix_options_parsing
overlookmotel
changed the base branch from
12-01-fix_linter_no-magic-numbers_fix_options_parsing
to
graphite-base/16339
overlookmotel
force-pushed
the
graphite-base/16339
branch
from
43b9cc1 to
04d8ab9
Compare
overlookmotel
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
b77cfba to
eaeb0d4
Compare
overlookmotel
changed the base branch from
graphite-base/16339
to
12-01-perf_linter_only_clone_config_if_required
overlookmotel
commented
Dec 1, 2025
overlookmotel
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
eaeb0d4 to
eb5fff7
Compare
overlookmotel
force-pushed
the
12-01-perf_linter_only_clone_config_if_required
branch
from
04d8ab9 to
4e3338f
Compare
overlookmotel
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
eb5fff7 to
44db42f
Compare
graphite-app
bot
changed the base branch from
12-01-perf_linter_only_clone_config_if_required
to
graphite-base/16339
graphite-app
bot
force-pushed
the
graphite-base/16339
branch
from
4e3338f to
e31b2bd
Compare
graphite-app
bot
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
44db42f to
37781ad
Compare
graphite-app
bot
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
37781ad to
5a98c87
Compare
overlookmotel
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
5a98c87 to
eab0874
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors rule option storage to use Vec<serde_json::Value> instead of serde_json::Value (which was always a Value::Array), providing better type safety and eliminating runtime panics. The change affects how rule configurations are stored internally while maintaining the same external API behavior for rule configuration methods like from_configuration.
- Changed
ESLintRule.configfromOption<Value>toOption<Vec<Value>>whereSomealways contains a non-empty vector - Updated
ExternalPluginStore::add_optionsto acceptVec<Value>directly, removing unnecessary runtime assertions - Modified conversion logic to properly transform between internal storage format and the expected
from_configurationparameter format
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/oxc_linter/src/external_plugin_store.rs | Updated add_options method signature to accept Vec<Value> instead of Value, removed panic condition and outdated documentation |
| crates/oxc_linter/src/config/rules.rs | Changed ESLintRule.config type to Option<Vec<Value>>, updated conversion logic for from_configuration calls, modified serialization to handle new type, updated parse_rule_value return type, and fixed test assertions |
| crates/oxc_linter/src/config/config_store.rs | Updated test code to call add_options with Vec<Value> instead of Value::Array |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
approved these changes
Dec 2, 2025
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
from
eab0874 to
c51a380
Compare
graphite-app
bot
deleted the
12-01-refactor_linter_store_rule_options_as_vec_s
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
Rule options are always an array, so store them as a `Vec<Value>` instead of a single `Value` which is always a `Value::Array`. This gives better type safety.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rule options are always an array, so store them as a
Vec<Value>instead of a singleValuewhich is always aValue::Array. This gives better type safety.