Skip to content

Comments

refactor(tsgolint): extract tsgolint process spawning into a separate function#16337

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function
Dec 1, 2025
Merged

refactor(tsgolint): extract tsgolint process spawning into a separate function#16337
graphite-app[bot] merged 1 commit intomainfrom
c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 1, 2025

No description provided.

@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Dec 1, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16337 will not alter performance

Comparing c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function (55825bb) with main (b169e52)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This was referenced Dec 1, 2025
Merged
Merged
Merged
Merged
@camc314 camc314 force-pushed the c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function branch from 536f2c4 to 55825bb Compare December 1, 2025 14:18
@camc314 camc314 marked this pull request as ready for review December 1, 2025 15:52
Copilot AI review requested due to automatic review settings December 1, 2025 15:52
@camc314 camc314 force-pushed the c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function branch from 55825bb to 433261e Compare December 1, 2025 15:55
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
@camc314 camc314 self-assigned this Dec 1, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Dec 1, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Dec 1, 3:55 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 3:58 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 1, 4:02 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Dec 1, 4:33 PM UTC: Merged by the Graphite merge queue.

Copilot AI reviewed Dec 1, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the tsgolint process spawning logic by extracting duplicate code into a new private spawn_tsgolint method. The refactoring consolidates process spawning, command argument configuration, and stdin writing that were previously duplicated in the lint and lint_source methods.

  • Extracted common tsgolint process spawning logic into a reusable spawn_tsgolint method
  • Replaced two instances of duplicated spawning code with calls to the new method
  • Simplified error handling by centralizing it in the extracted function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@camc314 camc314 force-pushed the c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function branch from 433261e to 5f451b8 Compare December 1, 2025 15:57
@camc314 camc314 added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Dec 1, 2025
@camc314 camc314 force-pushed the c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function branch 2 times, most recently from cb13664 to 5a40683 Compare December 1, 2025 16:05
@graphite-app graphite-app bot force-pushed the c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function branch from 5a40683 to 3983056 Compare December 1, 2025 16:28
@graphite-app graphite-app bot merged commit 3983056 into main Dec 1, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/12-01-refactor_tsgolint_extract_tsgolint_process_spawning_into_a_separate_function branch December 1, 2025 16:33
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
@camc314 camc314 mentioned this pull request Dec 2, 2025
Merged
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@camc314 @taearls
refactor(tsgolint): extract tsgolint process spawning into a separate…
ab333fb 
… function (oxc-project#16337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314