Skip to content

refactor(syntax): add #[inline] attribute to ScopeFlags::is_ts_conditional#16309

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-30-refactor_syntax_add_inline_attribute_to_scopeflags_is_ts_conditional_
Dec 1, 2025
Merged

refactor(syntax): add #[inline] attribute to ScopeFlags::is_ts_conditional#16309
graphite-app[bot] merged 1 commit intomainfrom
11-30-refactor_syntax_add_inline_attribute_to_scopeflags_is_ts_conditional_

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Nov 30, 2025 •
edited
Loading

Add #[inline] attr to this method, for consistency with all the rest.

This omission was spotted by @aapoalas in #16291.

@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Nov 30, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 30, 2025
@overlookmotel overlookmotel marked this pull request as ready for review November 30, 2025 23:52
Copilot AI review requested due to automatic review settings November 30, 2025 23:52
Copilot AI reviewed Nov 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the #[inline] attribute to the ScopeFlags::is_ts_conditional method to align it with the established pattern where all predicate methods in the ScopeFlags implementation use this attribute for performance optimization.

  • Adds #[inline] attribute to is_ts_conditional method for consistency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel
Copy link
Copy Markdown
Member Author

overlookmotel commented Nov 30, 2025

Uncontroversial change, so merging without review.

@overlookmotel overlookmotel self-assigned this Nov 30, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 30, 2025
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Nov 30, 2025 •
edited by graphite-app bot
Loading

Merge activity

@overlookmotel overlookmotel mentioned this pull request Nov 30, 2025
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 30, 2025

CodSpeed Performance Report

Merging #16309 will not alter performance

Comparing 11-30-refactor_syntax_add_inline_attribute_to_scopeflags_is_ts_conditional_ (bfb99eb) with main (10a793e)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on main (94320ab) during the generation of this report, so 10a793e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel
refactor(syntax): add #[inline] attribute to `ScopeFlags::is_ts_con…
43a6c32 
…ditional` (#16309)

Add `#[inline]` attr to this method, for consistency with all the rest.

This omission was spotted by @aapoalas in #16291.
@graphite-app graphite-app bot force-pushed the 11-30-refactor_syntax_add_inline_attribute_to_scopeflags_is_ts_conditional_ branch from bfb99eb to 43a6c32 Compare November 30, 2025 23:58
@graphite-app graphite-app bot merged commit 43a6c32 into main Dec 1, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-30-refactor_syntax_add_inline_attribute_to_scopeflags_is_ts_conditional_ branch December 1, 2025 00:04
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 1, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@overlookmotel @taearls
refactor(syntax): add #[inline] attribute to `ScopeFlags::is_ts_con…
f0e0936 
…ditional` (oxc-project#16309)

Add `#[inline]` attr to this method, for consistency with all the rest.

This omission was spotted by @aapoalas in oxc-project#16291.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel