refactor(formatter): Remove unused multiline comment check in ternary#16230
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 28, 2025
Conversation
github-actions
bot
added
A-formatter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #16230 will not alter performanceComparing Summary
Footnotes
|
Dunqing
approved these changes
Nov 28, 2025
Member
Merge activity
|
…#16230) Follow up #16224 > - Biome > - The same logic still exists > - https://github.com/biomejs/biome/blob/e7e0f6c14df92d83d08f86b1e57fc82b4df775b7/crates/biome_js_formatter/src/utils/conditional.rs#L197 > - In either case, the test did not fail > - always returning `false` > - removing related code like our diff above > - Prettier > - The most relevant lines are here > - https://github.com/prettier/prettier/blob/fd69335e513232c9b7aad78c93b42d8d3dd00ae7/src/language-js/print/ternary-old.js#L326-L344 > - As you expected, if change this to `const shouldBreak = false`, the test did not fail! From #16224 (comment)
graphite-app
bot
force-pushed
the
11-28-fix_formatter_print_comment_in_ternary_jsx
branch
from
b2bfa61 to
ac3a92e
Compare
graphite-app
bot
force-pushed
the
11-28-refactor_formatter_remove_unused_multiline_comment_check_in_ternary
branch
from
1a47fed to
03f5729
Compare
Base automatically changed from
11-28-fix_formatter_print_comment_in_ternary_jsx
to
main
November 28, 2025 07:18
graphite-app
bot
deleted the
11-28-refactor_formatter_remove_unused_multiline_comment_check_in_ternary
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…oxc-project#16230) Follow up oxc-project#16224 > - Biome > - The same logic still exists > - https://github.com/biomejs/biome/blob/e7e0f6c14df92d83d08f86b1e57fc82b4df775b7/crates/biome_js_formatter/src/utils/conditional.rs#L197 > - In either case, the test did not fail > - always returning `false` > - removing related code like our diff above > - Prettier > - The most relevant lines are here > - https://github.com/prettier/prettier/blob/fd69335e513232c9b7aad78c93b42d8d3dd00ae7/src/language-js/print/ternary-old.js#L326-L344 > - As you expected, if change this to `const shouldBreak = false`, the test did not fail! From oxc-project#16224 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #16224
From #16224 (comment)