Skip to content

Comments

refactor(formatter, transformer): use Expression::is_jsx to simplify JSX checks#16155

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-26-refactor_formatter_transformer_use_expression_is_jsx_to_simplify_jsx_checks
Nov 26, 2025
Merged

refactor(formatter, transformer): use Expression::is_jsx to simplify JSX checks#16155
graphite-app[bot] merged 1 commit intomainfrom
11-26-refactor_formatter_transformer_use_expression_is_jsx_to_simplify_jsx_checks

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 26, 2025 •
edited
Loading

Pure refactor

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler A-formatter Area - Formatter labels Nov 26, 2025
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Nov 26, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Nov 26, 2025
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 26, 2025
@Dunqing Dunqing mentioned this pull request Nov 26, 2025
Merged
@Dunqing Dunqing marked this pull request as ready for review November 26, 2025 10:20
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #16155 will not alter performance

Comparing 11-26-refactor_formatter_transformer_use_expression_is_jsx_to_simplify_jsx_checks (d003dcf) with main (17a8caa)1

Summary

✅ 38 untouched
⏩ 7 skipped2

Footnotes

  1. No successful run was found on 11-26-feat_ast_add_expression_is_jsx_method (6f7e6b1) during the generation of this report, so main (17a8caa) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 26, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the 11-26-feat_ast_add_expression_is_jsx_method branch from 6f7e6b1 to 669afe0 Compare November 26, 2025 11:30
@graphite-app graphite-app bot force-pushed the 11-26-refactor_formatter_transformer_use_expression_is_jsx_to_simplify_jsx_checks branch from d003dcf to ac9ae95 Compare November 26, 2025 11:30
Base automatically changed from 11-26-feat_ast_add_expression_is_jsx_method to main November 26, 2025 11:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 26, 2025
@graphite-app graphite-app bot merged commit ac9ae95 into main Nov 26, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-26-refactor_formatter_transformer_use_expression_is_jsx_to_simplify_jsx_checks branch November 26, 2025 11:36
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@Dunqing @taearls
refactor(formatter, transformer): use Expression::is_jsx to simplif…
f6a5624 
…y JSX checks (oxc-project#16155)

Pure refactor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees

No one assigned

Labels

A-formatter Area - Formatter A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dunqing