Skip to content

Comments

chore(dx): report unused disable directives for vscode extension#16059

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-24-chore_dx_report_unused_disable_directives_for_vscode_extension
Nov 24, 2025
Merged

chore(dx): report unused disable directives for vscode extension#16059
graphite-app[bot] merged 1 commit intomainfrom
11-24-chore_dx_report_unused_disable_directives_for_vscode_extension

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Nov 24, 2025 •
edited
Loading

follow up from #16015

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 24, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented Nov 24, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review November 24, 2025 13:38
Copilot AI review requested due to automatic review settings November 24, 2025 13:38
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025
@Sysix Graphite App
Copy link
Member Author

Sysix commented Nov 24, 2025 •
edited by graphite-app bot
Loading

Merge activity

Copilot AI reviewed Nov 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR configures the VSCode extension to report unused disable directives (like // oxlint-disable-line) as errors. This is a follow-up improvement to enhance developer experience by ensuring that disable directives are only used when necessary, preventing code clutter from outdated or unnecessary suppressions.

  • Adds "oxc.unusedDisableDirectives": "deny" to the workspace settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot force-pushed the 11-24-chore_dx_report_unused_disable_directives_for_vscode_extension branch from b32c2fa to 0069b04 Compare November 24, 2025 13:43
@graphite-app graphite-app bot merged commit 0069b04 into main Nov 24, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 11-24-chore_dx_report_unused_disable_directives_for_vscode_extension branch November 24, 2025 13:48
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 24, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@Sysix @taearls
chore(dx): report unused disable directives for vscode extension (oxc…
00627c0 
…-project#16059)

follow up from oxc-project#16015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees

No one assigned

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sysix @overlookmotel