ci(apps, napi): skip linting files generated by NAPI-RS#16013
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 23, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 23, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds ignore patterns to oxlintrc.json to exclude NAPI-RS generated files from linting. These files contain /* eslint-disable */ comments that can cause "Unused eslint-disable directive" warnings when linted.
Key changes:
- Added 7 new ignore patterns for NAPI-RS generated files including
.d.ts,.wasi.cjs,wasi-worker-browser.mjs, andwebcontainer-fallback.cjsfiles - Patterns target files in the
napi/directory structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
11-23-ci_apps_napi_skip_linting_files_generated_by_napi-rs
branch
2 times, most recently
from
a3bb641 to
deefcb0
Compare
Contributor
Merge activity
|
Disable Oxlint for files generated by NAPI-RS. These files already have `/* eslint-disable */` comments, but some of those comments are unnecessary, so linting them generates "Unused eslint-disable directive" errors.
graphite-app
bot
force-pushed
the
11-23-ci_apps_napi_skip_linting_files_generated_by_napi-rs
branch
from
deefcb0 to
1ea385c
Compare
graphite-app
bot
deleted the
11-23-ci_apps_napi_skip_linting_files_generated_by_napi-rs
branch
overlookmotel
added a commit
that referenced
this pull request
Nov 24, 2025
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…16013) Disable Oxlint for files generated by NAPI-RS. These files already have `/* eslint-disable */` comments, but some of those comments are unnecessary, so linting them generates "Unused eslint-disable directive" errors.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…6015) After oxc-project#16013, oxc-project#16014, and oxc-project#16053, we can now enable checking for unused `oxlint-disable` comments in our linting setup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable Oxlint for files generated by NAPI-RS.
These files already have
/* eslint-disable */comments, but some of those comments are unnecessary, so linting them generates "Unused eslint-disable directive" errors.