Skip to content

Comments

refactor(linter/plugins): add debugAssert function#15969

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-22-refactor_linter_plugins_add_debugassert_function
Nov 22, 2025
Merged

refactor(linter/plugins): add debugAssert function#15969
graphite-app[bot] merged 1 commit intomainfrom
11-22-refactor_linter_plugins_add_debugassert_function

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 22, 2025

Add a debugAssert function, which works the same as debug_assert! in Rust. We can use this to add more assertions to rest of code.

Same as debugAssertIsNonNull and typeAssertIs, this function will be removed entirely in release build - it only performs the check in debug build (which is used in the tests).

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins labels Nov 22, 2025
Copy link
Member Author

overlookmotel commented Nov 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 22, 2025
@overlookmotel overlookmotel force-pushed the 11-22-refactor_linter_plugins_add_debugassert_function branch from b75558a to 8334f46 Compare November 22, 2025 15:42
@overlookmotel overlookmotel marked this pull request as ready for review November 22, 2025 15:42
@overlookmotel overlookmotel self-assigned this Nov 22, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 22, 2025
Copy link
Member Author

overlookmotel commented Nov 22, 2025

Merge activity

Add a `debugAssert` function, which works the same as `debug_assert!` in Rust. We can use this to add more assertions to rest of code.

Same as `debugAssertIsNonNull` and `typeAssertIs`, this function will be removed entirely in release build - it only performs the check in debug build (which is used in the tests).
@graphite-app graphite-app bot force-pushed the 11-22-refactor_linter_plugins_rename_assertion_functions branch from fa9143e to ae13704 Compare November 22, 2025 15:54
@graphite-app graphite-app bot force-pushed the 11-22-refactor_linter_plugins_add_debugassert_function branch from 8334f46 to 0a6a288 Compare November 22, 2025 15:54
Base automatically changed from 11-22-refactor_linter_plugins_rename_assertion_functions to main November 22, 2025 16:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 22, 2025
@graphite-app graphite-app bot merged commit 0a6a288 into main Nov 22, 2025
19 checks passed
@graphite-app graphite-app bot deleted the 11-22-refactor_linter_plugins_add_debugassert_function branch November 22, 2025 16:00
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Add a `debugAssert` function, which works the same as `debug_assert!` in Rust. We can use this to add more assertions to rest of code.

Same as `debugAssertIsNonNull` and `typeAssertIs`, this function will be removed entirely in release build - it only performs the check in debug build (which is used in the tests).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant