refactor(linter/plugins): rename assertion functions#15968
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 22, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors assertion functions to clarify their intended usage and limitations. The functions are renamed from assertIs to typeAssertIs and assertIsNonNull to debugAssertIsNonNull, making it explicit that these are not traditional runtime assertions suitable for input validation. The typeAssertIs function is purely for compile-time type checking with zero runtime cost, while debugAssertIsNonNull performs runtime checks only in debug builds.
Key changes:
- Renamed
assertIstotypeAssertIsto clarify it's a compile-time type assertion - Renamed
assertIsNonNulltodebugAssertIsNonNullto indicate debug-only runtime behavior - Updated all import statements and call sites consistently across 12 files
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/src-js/utils/asserts.ts | Function definitions renamed: assertIs → typeAssertIs, assertIsNonNull → debugAssertIsNonNull |
| apps/oxlint/src-js/plugins/visitor.ts | Updated imports and 4 call sites to use new function names |
| apps/oxlint/src-js/plugins/tokens.ts | Updated imports and 4 call sites to use debugAssertIsNonNull |
| apps/oxlint/src-js/plugins/source_code.ts | Updated imports and 5 call sites to use debugAssertIsNonNull |
| apps/oxlint/src-js/plugins/settings.ts | Updated imports and 1 call site to use debugAssertIsNonNull |
| apps/oxlint/src-js/plugins/scope.ts | Updated imports and 5 call sites to use new function names |
| apps/oxlint/src-js/plugins/location.ts | Updated imports and 3 call sites to use debugAssertIsNonNull |
| apps/oxlint/src-js/plugins/lint.ts | Updated imports and 3 call sites to use new function names |
| apps/oxlint/src-js/plugins/fix.ts | Updated imports and 1 call site to use typeAssertIs |
| apps/oxlint/src-js/plugins/context.ts | Updated imports and 3 call sites to use debugAssertIsNonNull |
| apps/oxlint/src-js/plugins/comments.ts | Updated imports and 6 call sites to use debugAssertIsNonNull |
| apps/oxlint/src-js/index.ts | Updated imports and 1 call site to use debugAssertIsNonNull |
| apps/oxlint/src-js/cli.ts | Updated imports and 2 call sites to use debugAssertIsNonNull |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Merge activity
|
Rename assertion functions to clarify that they're not "real" assertions which we can rely on for validating input, and are only for compile-time testing or debug assertions. `typeAssertIs` is not a great name, but I couldn't come up with anything better. `debugAssertIs` would be not be accurate, as it'd imply that in debug builds in performs an actual assertion, which it doesn't. In any case, we should replace `typeAssertIs` with specialized assertion functions which do actually perform runtime assertions in debug builds (e.g. `typeAssertIs<Fix>()` -> `debugAssertIsFix()`).
graphite-app
bot
force-pushed
the
11-22-refactor_linter_plugins_rename_assertion_functions
branch
from
fa9143e to
ae13704
Compare
graphite-app
bot
deleted the
11-22-refactor_linter_plugins_rename_assertion_functions
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
Rename assertion functions to clarify that they're not "real" assertions which we can rely on for validating input, and are only for compile-time testing or debug assertions. `typeAssertIs` is not a great name, but I couldn't come up with anything better. `debugAssertIs` would be not be accurate, as it'd imply that in debug builds in performs an actual assertion, which it doesn't. In any case, we should replace `typeAssertIs` with specialized assertion functions which do actually perform runtime assertions in debug builds (e.g. `typeAssertIs<Fix>()` -> `debugAssertIsFix()`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename assertion functions to clarify that they're not "real" assertions which we can rely on for validating input, and are only for compile-time testing or debug assertions.
typeAssertIsis not a great name, but I couldn't come up with anything better.debugAssertIswould be not be accurate, as it'd imply that in debug builds it performs an actual runtime assertion, which it doesn't.In any case, we should replace
typeAssertIswith specialized assertion functions which do actually perform runtime assertions in debug builds (e.g.typeAssertIs<Fix>(fix)->debugAssertIsFix(fix)).