Skip to content

Comments

refactor(linter): replace range with span in tsgolint diagnostics#15965

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-22-refactor_linter_replace_range_with_span_in_tsgolint_diagnostics
Nov 23, 2025
Merged

refactor(linter): replace range with span in tsgolint diagnostics#15965
graphite-app[bot] merged 1 commit intomainfrom
c/11-22-refactor_linter_replace_range_with_span_in_tsgolint_diagnostics

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 22, 2025

No description provided.

@github-actions github-actions bot added the A-linter Area - Linter label Nov 22, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 22, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 22, 2025
@camc314 camc314 mentioned this pull request Nov 22, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15965 will not alter performance

Comparing c/11-22-refactor_linter_replace_range_with_span_in_tsgolint_diagnostics (27513a4) with c/11-22-fix_linter_support_missing_range_for_internal_diagnostics (ebb4c61)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 force-pushed the c/11-22-fix_linter_support_missing_range_for_internal_diagnostics branch from d4747c6 to ebb4c61 Compare November 22, 2025 19:52
@camc314 camc314 force-pushed the c/11-22-refactor_linter_replace_range_with_span_in_tsgolint_diagnostics branch from 1cbc204 to 27513a4 Compare November 22, 2025 19:52
@camc314 camc314 marked this pull request as ready for review November 22, 2025 19:53
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 22, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 22, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 22, 7:53 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 22, 8:02 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 22, 8:05 PM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
  • Nov 23, 7:23 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 23, 7:23 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Nov 23, 7:34 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Nov 23, 7:37 PM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from c/11-22-fix_linter_support_missing_range_for_internal_diagnostics to graphite-base/15965 November 22, 2025 19:58
@graphite-app graphite-app bot changed the base branch from graphite-base/15965 to main November 22, 2025 20:04
@github-actions github-actions bot added the A-cli Area - CLI label Nov 22, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 22, 2025
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 23, 2025
@camc314 camc314 force-pushed the c/11-22-refactor_linter_replace_range_with_span_in_tsgolint_diagnostics branch from 27513a4 to 631a621 Compare November 23, 2025 19:23
Copilot AI review requested due to automatic review settings November 23, 2025 19:23
Copilot AI reviewed Nov 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the internal diagnostic types (TsGoLintRuleDiagnostic and TsGoLintInternalDiagnostic) to use Span instead of Range for position tracking. The Range type remains in use for JSON deserialization from the external tsgolint tool, with conversions happening at the deserialization boundaries.

Key changes:

  • Replace range: Range with span: Span in diagnostic structs
  • Update conversion logic to map Range to Span when deserializing
  • Simplify code that previously constructed Span from Range fields

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 force-pushed the c/11-22-refactor_linter_replace_range_with_span_in_tsgolint_diagnostics branch from 631a621 to faf7040 Compare November 23, 2025 19:26
@graphite-app graphite-app bot force-pushed the c/11-22-refactor_linter_replace_range_with_span_in_tsgolint_diagnostics branch from faf7040 to 6f6e609 Compare November 23, 2025 19:33
@graphite-app graphite-app bot merged commit 6f6e609 into main Nov 23, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/11-22-refactor_linter_replace_range_with_span_in_tsgolint_diagnostics branch November 23, 2025 19:37
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@camc314 @taearls
refactor(linter): replace range with span in tsgolint diagnostics (…
236e7f2 
…oxc-project#15965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314