Skip to content

Comments

test(formatter): Test default printWidth as well#15934

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-21-test_formatter_test_default_options
Nov 21, 2025
Merged

test(formatter): Test default printWidth as well#15934
graphite-app[bot] merged 1 commit intomainfrom
11-21-test_formatter_test_default_options

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Nov 21, 2025

Follow up #15933

  • Also tests with default printWidth
  • Refactored options printing for snapshot

@leaysgur leaysgur requested a review from Dunqing as a code owner November 21, 2025 05:15
@github-actions github-actions bot added A-formatter Area - Formatter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 21, 2025
Copy link
Member Author

leaysgur commented Nov 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur force-pushed the 11-21-test_formatter_test_default_options branch 2 times, most recently from ae15af6 to 2fff36f Compare November 21, 2025 05:22
@leaysgur leaysgur changed the title test(formatter): Test default options test(formatter): Test default printWidth as well Nov 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025

CodSpeed Performance Report

Merging #15934 will not alter performance

Comparing 11-21-test_formatter_test_default_options (2fff36f) with 11-21-feat_formatter_default_linewidth_100 (4fd71ed)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2025
Copy link
Member Author

leaysgur commented Nov 21, 2025

Merge activity

Follow up #15933

- Also tests with default `printWidth`
- Refactored options printing for snapshot
@graphite-app graphite-app bot force-pushed the 11-21-feat_formatter_default_linewidth_100 branch from 4fd71ed to a937890 Compare November 21, 2025 07:02
@graphite-app graphite-app bot force-pushed the 11-21-test_formatter_test_default_options branch from 2fff36f to efbaefd Compare November 21, 2025 07:03
Base automatically changed from 11-21-feat_formatter_default_linewidth_100 to main November 21, 2025 07:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 21, 2025
@graphite-app graphite-app bot merged commit efbaefd into main Nov 21, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-21-test_formatter_test_default_options branch November 21, 2025 07:09
Copilot AI pushed a commit that referenced this pull request Nov 21, 2025
Follow up #15933

- Also tests with default `printWidth`
- Refactored options printing for snapshot
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Follow up oxc-project#15933

- Also tests with default `printWidth`
- Refactored options printing for snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants