Skip to content

refactor(all)!: remove binding pattern wierdness#15925

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/11-21-refactor_all_remove_binding_pattern_wierdness
Dec 22, 2025
Merged

refactor(all)!: remove binding pattern wierdness#15925
graphite-app[bot] merged 1 commit into
mainfrom
c/11-21-refactor_all_remove_binding_pattern_wierdness

Conversation

@camc314

@camc314 camc314 commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

fixes #11489

Note, in quite a few places i changed the span we report on to look something like this, the only reason for this is to reduce the diff in some of the snapshots

decl.type_annotation.as_ref().map_or_else(
                        || decl.id.span(),
                        |type_annotation| decl.id.span().merge(type_annotation.span()),
                    ),

@camc314
camc314 marked this pull request as ready for review November 21, 2025 00:01
Copilot AI review requested due to automatic review settings November 21, 2025 00:01
@camc314
camc314 requested a review from Dunqing as a code owner November 21, 2025 00:01
@github-actions github-actions Bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools A-formatter Area - Formatter A-linter-plugins Area - Linter JS plugins labels Nov 21, 2025
@camc314 Graphite App

camc314 commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 21, 2025
@camc314
camc314 marked this pull request as draft November 21, 2025 00:01
@camc314
camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch 5 times, most recently from b41648c to 497689d Compare November 21, 2025 00:05
camc314
camc314 commented Nov 21, 2025
View reviewed changes
Comment thread crates/oxc_ast/src/ast/js.rs
@codspeed-hq

codspeed-hq Bot commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #15925 will not alter performance

Comparing c/11-21-refactor_all_remove_binding_pattern_wierdness (4d4b85e) with main (2d556cb)

Summary

✅ 42 untouched
⏩ 3 skipped1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314
camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch 2 times, most recently from fb8fd1d to a46b36c Compare November 21, 2025 00:13
@overlookmotel overlookmotel removed the A-linter-plugins Area - Linter JS plugins label Dec 1, 2025
@camc314
camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from 3f8218e to 21ccffa Compare December 9, 2025 14:05
@github-actions github-actions Bot added the A-linter-plugins Area - Linter JS plugins label Dec 9, 2025
@camc314
camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch 6 times, most recently from c7c26a3 to cb33768 Compare December 10, 2025 15:01
@camc314 camc314 changed the title refactor(all): remove binding pattern wierdness refactor(all)!: remove binding pattern wierdness Dec 10, 2025
@camc314
camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch 2 times, most recently from dbbda2a to fbac3c5 Compare December 10, 2025 15:14
@camc314
camc314 marked this pull request as ready for review December 10, 2025 15:15
@camc314

camc314 commented Dec 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@overlookmotel this should be ready for review 🙏 .

I also tested this in rolldown, and although rolldown requires changes, no tests fail - it all looks OK 👌

@camc314
camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from fbac3c5 to 9807b77 Compare December 10, 2025 15:16
@Boshen

Boshen commented Dec 11, 2025

Copy link
Copy Markdown
Member

🐐

@camc314
camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch 2 times, most recently from 7441ca1 to 45f242e Compare December 15, 2025 10:21
@camc314
camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from 45f242e to 76a0c6d Compare December 19, 2025 14:05
This was referenced Dec 19, 2025
Merged
Merged
Merged
@camc314 Graphite App

camc314 commented Dec 22, 2025 •
edited by graphite-app Bot
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

@camc314
refactor(all)!: remove binding pattern wierdness (#15925)
3984750 
fixes #11489

Note, in quite a few places i changed the span we report on to look something like this, the only reason for this is to reduce the diff in some of the snapshots
```
decl.type_annotation.as_ref().map_or_else(
                        || decl.id.span(),
                        |type_annotation| decl.id.span().merge(type_annotation.span()),
                    ),
```
@overlookmotel overlookmotel mentioned this pull request Dec 22, 2025
Closed
@Dunqing Dunqing mentioned this pull request Dec 22, 2025
Merged
@camc314 camc314 mentioned this pull request Dec 23, 2025
Merged
@Dunqing Dunqing mentioned this pull request Jan 3, 2026
Merged
@overlookmotel overlookmotel mentioned this pull request Mar 20, 2026
Merged
@overlookmotel overlookmotel mentioned this pull request Apr 1, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner
@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

@overlookmotel overlookmotel

@camc314 camc314

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-cli Area - CLI A-codegen Area - Code Generation A-formatter Area - Formatter A-isolated-declarations Isolated Declarations A-linter Area - Linter A-linter-plugins Area - Linter JS plugins A-minifier Area - Minifier A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor BindingPattern to remove weirdness

4 participants

@camc314 @Boshen @overlookmotel