refactor(linter/plugins): remove noExternal from TSDown config#15872
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 19, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-linter
This was referenced Nov 19, 2025
overlookmotel
force-pushed
the
11-19-refactor_linter_plugins_remove_noexternal_from_tsdown_config
branch
from
8785cc1 to
767a867
Compare
overlookmotel
force-pushed
the
11-19-fix_linter_plugins_correct_bindings_package_names_glob_in_tsdown_config
branch
from
9d08c5c to
0347480
Compare
overlookmotel
added
A-linter-plugins
Contributor
Merge activity
|
graphite-app
bot
changed the base branch from
11-19-fix_linter_plugins_correct_bindings_package_names_glob_in_tsdown_config
to
graphite-base/15872
camc314
approved these changes
Nov 19, 2025
graphite-app
bot
force-pushed
the
11-19-refactor_linter_plugins_remove_noexternal_from_tsdown_config
branch
from
767a867 to
3478edb
Compare
graphite-app
bot
deleted the
11-19-refactor_linter_plugins_remove_noexternal_from_tsdown_config
branch
29 tasks
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…-project#15872) `noExternal` is not required. As long as the dependency is not specified in `package.json`'s `dependencies`, it's not externalized. I've verified that the code for `@typescript-eslint/scope-manager` is still present in `dist/plugins.js` after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noExternalis not required. As long as the dependency is not specified inpackage.json'sdependencies, it's not externalized.I've verified that the code for
@typescript-eslint/scope-manageris still present indist/plugins.jsafter this change.