chore(vscode): second language server connection for `oxfmt` by Sysix · Pull Request #15837 · oxc-project/oxc

Sysix · 2025-11-18T12:13:00Z

This PR implements a second language server connection only for oxfmt. Currently, it still uses the shipped oxc_language_server binary for formatting. When defining a custom oxc.path.oxlint (or oxc.path.server), it will start the search process for node_modules/.bin/oxfmt or uses oxc.path.oxfmt.

This should be not a breaking change. When node_modules/.bin/oxfmt should be required for formatting, the ConfigService.useOxcLanguageServerForFormatting must not be modified. I would love to wait for the correct search implementation for .node_modules/.bin/oxlint before breaking the server detection (and probably removing the shipped server too).

Default / with `oxfmt` installed:

Using the internal language server (once)

with `oxc.path.oxlint`:

Using the oxlint path server for linting.
Searching for oxfmt inside node_modules/.bin

with `oxc.path.fmt`:

Using the internal language server for linting.
Using oxc.path.fmt binary

Sysix · 2025-11-18T12:13:15Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

editors/vscode/client/tools/formatter.ts

camc314 · 2025-12-02T22:40:45Z

@leaysgur you probably want to review this? If not, I'm happy to

editors/vscode/client/tools/formatter.ts

leaysgur · 2025-12-02T23:54:45Z

@camc314 I left a comment, so I will get back to you. 🙏🏻

camc314 · 2025-12-05T15:47:02Z

Merge activity

Dec 5, 3:47 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 5, 3:47 PM UTC: camc314 added this pull request to the Graphite merge queue.
Dec 5, 3:57 PM UTC: Merged by the Graphite merge queue.

This PR implements a second language server connection only for `oxfmt`. Currently, it still uses the shipped `oxc_language_server` binary for formatting. When defining a custom `oxc.path.oxlint` (or `oxc.path.server`), it will start the search process for `node_modules/.bin/oxfmt` or uses `oxc.path.oxfmt`. This should be **not** a breaking change. When `node_modules/.bin/oxfmt` should be required for formatting, the `ConfigService.useOxcLanguageServerForFormatting` must not be modified. I would love to wait for the correct search implementation for `.node_modules/.bin/oxlint` before breaking the server detection (and probably removing the shipped server too). ### Default / with `oxfmt` installed: Using the internal language server (once) ### with `oxc.path.oxlint`: Using the oxlint path server for linting. Searching for `oxfmt` inside `node_modules/.bin` ### with `oxc.path.fmt`: Using the internal language server for linting. Using `oxc.path.fmt` binary <img width="257" height="233" alt="grafik" src="https://github.com/user-attachments/assets/0776920d-76cd-49cf-9357-fae2ea4a0eb8" /> <img width="193" height="238" alt="grafik" src="https://github.com/user-attachments/assets/c3b2670d-559e-4d0a-96b2-b420e868e1a1" /> <img width="174" height="258" alt="grafik" src="https://github.com/user-attachments/assets/63f9a265-cae9-4971-9c21-86adeacaf35d" />

…ject#15837) This PR implements a second language server connection only for `oxfmt`. Currently, it still uses the shipped `oxc_language_server` binary for formatting. When defining a custom `oxc.path.oxlint` (or `oxc.path.server`), it will start the search process for `node_modules/.bin/oxfmt` or uses `oxc.path.oxfmt`. This should be **not** a breaking change. When `node_modules/.bin/oxfmt` should be required for formatting, the `ConfigService.useOxcLanguageServerForFormatting` must not be modified. I would love to wait for the correct search implementation for `.node_modules/.bin/oxlint` before breaking the server detection (and probably removing the shipped server too). ### Default / with `oxfmt` installed: Using the internal language server (once) ### with `oxc.path.oxlint`: Using the oxlint path server for linting. Searching for `oxfmt` inside `node_modules/.bin` ### with `oxc.path.fmt`: Using the internal language server for linting. Using `oxc.path.fmt` binary <img width="257" height="233" alt="grafik" src="https://github.com/user-attachments/assets/0776920d-76cd-49cf-9357-fae2ea4a0eb8" /> <img width="193" height="238" alt="grafik" src="https://github.com/user-attachments/assets/c3b2670d-559e-4d0a-96b2-b420e868e1a1" /> <img width="174" height="258" alt="grafik" src="https://github.com/user-attachments/assets/63f9a265-cae9-4971-9c21-86adeacaf35d" />

Sysix mentioned this pull request Nov 18, 2025

refactor(vscode): add WorkspaceConfig methods for different lsp tools #15788

Merged

github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 18, 2025

Sysix mentioned this pull request Nov 18, 2025

refactor(vscode): split lsp releated code to linter.ts #15789

Merged

Sysix force-pushed the 11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_ branch from df6d604 to cc0ec55 Compare November 18, 2025 12:13

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from 0a8f773 to 99701c2 Compare November 18, 2025 12:13

graphite-app bot force-pushed the 11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_ branch 2 times, most recently from 56be34f to f7ff45d Compare November 18, 2025 12:26

graphite-app bot force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from 96a9a86 to d5ec71f Compare November 18, 2025 12:26

Sysix force-pushed the 11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_ branch from f7ff45d to 240f96d Compare November 18, 2025 14:48

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from d5ec71f to 1ec9472 Compare November 18, 2025 14:48

Sysix force-pushed the 11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_ branch from 240f96d to e919504 Compare November 18, 2025 15:21

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from 1ec9472 to cce5a20 Compare November 18, 2025 15:21

Sysix changed the base branch from 11-17-refactor_vscode_split_lsp_releated_code_to_linter.ts_ to graphite-base/15837 November 18, 2025 15:33

Sysix force-pushed the graphite-base/15837 branch from e919504 to 784a33c Compare November 18, 2025 16:33

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from cce5a20 to 0fa8b4c Compare November 18, 2025 16:33

Sysix changed the base branch from graphite-base/15837 to 11-18-refacor_vscode_run_js_language_server_with_node_ November 18, 2025 16:33

Sysix mentioned this pull request Nov 18, 2025

refactor(vscode): run js language server with node #15845

Merged

Sysix changed the base branch from 11-18-refacor_vscode_run_js_language_server_with_node_ to graphite-base/15837 November 19, 2025 17:15

graphite-app bot force-pushed the graphite-base/15837 branch from 784a33c to 0146b4c Compare November 19, 2025 17:25

graphite-app bot force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from 0fa8b4c to 35a58e9 Compare November 19, 2025 17:25

graphite-app bot changed the base branch from graphite-base/15837 to main November 19, 2025 17:25

graphite-app bot force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from 35a58e9 to f61e18a Compare November 19, 2025 17:26

Sysix changed the base branch from main to graphite-base/15837 November 21, 2025 16:47

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from f61e18a to f535ff0 Compare November 21, 2025 16:47

Sysix changed the base branch from graphite-base/15837 to 11-21-refactor_vscode_add_lsp_helper_runexecutable_ November 21, 2025 16:47

This was referenced Nov 21, 2025

test(vscode): testsetup for oxfmt --lsp server #15883

Merged

refactor(vscode): add lsp helper runExecutable #15950

Merged

Sysix changed the base branch from 11-21-refactor_vscode_add_lsp_helper_runexecutable_ to graphite-base/15837 November 21, 2025 17:15

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch 2 times, most recently from 0932a4b to eef3fe2 Compare November 25, 2025 15:39

Sysix marked this pull request as ready for review November 25, 2025 15:45

Sysix requested review from camc314 as code owners November 25, 2025 15:45

leaysgur reviewed Nov 26, 2025

View reviewed changes

editors/vscode/client/tools/formatter.ts Outdated Show resolved Hide resolved

leaysgur mentioned this pull request Nov 26, 2025

docs(oxfmt): Include links for the VS Code extension in the formatter FAQ oxc-project/website#658

Merged

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from eef3fe2 to ac599cb Compare November 27, 2025 15:46

connorshea mentioned this pull request Nov 29, 2025

linter: LSP warnings without Oxlint config #16254

Closed

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from ac599cb to 95542bd Compare December 2, 2025 19:10

camc314 requested a review from leaysgur December 2, 2025 22:40

camc314 assigned leaysgur Dec 2, 2025

leaysgur reviewed Dec 2, 2025

View reviewed changes

editors/vscode/client/tools/formatter.ts Show resolved Hide resolved

leaysgur assigned camc314 and unassigned leaysgur Dec 2, 2025

Sysix force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch 3 times, most recently from c623cc6 to df8baeb Compare December 4, 2025 23:16

camc314 approved these changes Dec 5, 2025

View reviewed changes

camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2025

graphite-app bot force-pushed the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch from df8baeb to 2fcc079 Compare December 5, 2025 15:51

graphite-app bot merged commit 2fcc079 into main Dec 5, 2025
19 checks passed

graphite-app bot deleted the 11-17-chore_vscode_second_language_server_connection_for_oxfmt_ branch December 5, 2025 15:57

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

chore(vscode): second language server connection for `oxfmt`#15837

chore(vscode): second language server connection for `oxfmt`#15837
graphite-app[bot] merged 1 commit intomainfrom
11-17-chore_vscode_second_language_server_connection_for_oxfmt_

Sysix commented Nov 18, 2025 •

edited

Loading

Uh oh!

Sysix commented Nov 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

camc314 commented Dec 2, 2025

Uh oh!

Uh oh!

leaysgur commented Dec 2, 2025

Uh oh!

camc314 commented Dec 5, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Comments

Conversation

Sysix commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Default / with oxfmt installed:

with oxc.path.oxlint:

with oxc.path.fmt:

Uh oh!

Sysix commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

camc314 commented Dec 2, 2025

Uh oh!

Uh oh!

leaysgur commented Dec 2, 2025

Uh oh!

camc314 commented Dec 5, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sysix commented Nov 18, 2025 •

edited

Loading

Default / with `oxfmt` installed:

with `oxc.path.oxlint`:

with `oxc.path.fmt`:

Sysix commented Nov 18, 2025 •

edited

Loading

camc314 commented Dec 5, 2025 •

edited by graphite-app bot

Loading