Skip to content

Comments

refactor(transformer/typescript): correct comment#15803

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-17-refactor_transformer_typescript_correct_comment
Nov 17, 2025
Merged

refactor(transformer/typescript): correct comment#15803
graphite-app[bot] merged 1 commit intomainfrom
11-17-refactor_transformer_typescript_correct_comment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Nov 17, 2025 •
edited
Loading

Follow-on after #15712. Correct a comment, based on AI review: #15712 (comment)

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 17, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 17, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review November 17, 2025 19:33
Copilot AI review requested due to automatic review settings November 17, 2025 19:33
@overlookmotel overlookmotel self-assigned this Nov 17, 2025
@overlookmotel overlookmotel removed the request for review from Dunqing November 17, 2025 19:33
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Nov 17, 2025 •
edited by graphite-app bot
Loading

Merge activity

Copilot AI reviewed Nov 17, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects a comment in the TypeScript namespace transformer based on feedback from an AI review. The change replaces a TODO question about whether TSGlobalDeclaration can be nested within TSModuleDeclaration with a definitive note confirming that this is legal syntax, along with an example.

Key Changes

  • Added period to "Remove it" comment for consistency
  • Replaced TODO question with a Note explaining that TSGlobalDeclaration nesting is legal when the module identifier is a string literal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 17, 2025

CodSpeed Performance Report

Merging #15803 will not alter performance

Comparing 11-17-refactor_transformer_typescript_correct_comment (a14dec8) with main (cbb27fd)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel
refactor(transformer/typescript): correct comment (#15803)
c167dfa 
Follow-on after #15712. Correct a comment, based on AI review: #15712 (comment)
@graphite-app graphite-app bot force-pushed the 11-17-refactor_transformer_typescript_correct_comment branch from a14dec8 to c167dfa Compare November 17, 2025 19:38
@graphite-app graphite-app bot merged commit c167dfa into main Nov 17, 2025
20 checks passed
@graphite-app graphite-app bot deleted the 11-17-refactor_transformer_typescript_correct_comment branch November 17, 2025 19:44
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 17, 2025
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@overlookmotel @taearls
refactor(transformer/typescript): correct comment (oxc-project#15803)
321bde6 
Follow-on after oxc-project#15712. Correct a comment, based on AI review: oxc-project#15712 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@overlookmotel