fix(span): add debug assertion for Span::new#15787
Closed
sapphi-red wants to merge 1 commit intomainfrom
Closed
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #15787 will not alter performanceComparing Summary
|
Member
|
This is good. Incorrect spans are a common cause of panics in linter. The more checks the better. I think we can go even further. It should always be true that |
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 19, 2025
This debug assertion failed https://github.com/oxc-project/oxc/blob/ef4cc33b5cedde82d5b5f91355d7b39436bdbcd6/crates/oxc_span/src/span.rs#L169 when it's called by https://github.com/oxc-project/oxc/blob/c023ba67e07283bad3a43ef9bcc0336c94aa42ae/crates/oxc_codegen/src/gen.rs#L2123 which was caused by https://github.com/oxc-project/oxc/blob/102365da3dd02f5cdd444eaf04f8bbf91c814886/crates/oxc_minifier/src/peephole/fold_constants.rs#L445 This PR fixes these kinds of issues. This PR adds a test but does not fail even without the change. I'll fail once #15787 is done.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
This debug assertion failed https://github.com/oxc-project/oxc/blob/ef4cc33b5cedde82d5b5f91355d7b39436bdbcd6/crates/oxc_span/src/span.rs#L169 when it's called by https://github.com/oxc-project/oxc/blob/c023ba67e07283bad3a43ef9bcc0336c94aa42ae/crates/oxc_codegen/src/gen.rs#L2123 which was caused by https://github.com/oxc-project/oxc/blob/102365da3dd02f5cdd444eaf04f8bbf91c814886/crates/oxc_minifier/src/peephole/fold_constants.rs#L445 This PR fixes these kinds of issues. This PR adds a test but does not fail even without the change. I'll fail once oxc-project#15787 is done.
Member
|
Close as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.