feat(allocator/vec): add Vec::into_bump_slice method#15770
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 17, 2025
Merged
feat(allocator/vec): add Vec::into_bump_slice method#15770graphite-app[bot] merged 1 commit intomainfrom
Vec::into_bump_slice method#15770graphite-app[bot] merged 1 commit intomainfrom
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new into_bump_slice method to the Vec type, which converts a Vec<T> into a borrowed slice &'alloc [T]. This provides a convenient way to convert arena-allocated vectors into slices with the same lifetime as the allocator.
Key Changes:
- Added
Vec::into_bump_slicemethod that delegates to the underlyingInnerVecimplementation - Included documentation with usage example
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CodSpeed Performance ReportMerging #15770 will not alter performanceComparing Summary
|
Dunqing
force-pushed
the
11-17-feat_allocator_vec_add_vec_into_bump_slice_method
branch
from
e9f5987 to
be713e8
Compare
overlookmotel
approved these changes
Nov 17, 2025
Member
Merge activity
|
Add an `into_bump_slice` method in `Vec` that directly delegates to the InnerVec's `into_bump_slice`. The reason we should add this method rather than using `InnerVec`'s `into_bump_slice` directly is that the method requires taking `self`, which doesn't work with `Deref`. The method comments are copied from InnerVec's, and the example has been changed to make it work with the current Vec.
graphite-app
bot
force-pushed
the
11-17-feat_allocator_vec_add_vec_into_bump_slice_method
branch
from
be713e8 to
102365d
Compare
graphite-app
bot
deleted the
11-17-feat_allocator_vec_add_vec_into_bump_slice_method
branch
overlookmotel
pushed a commit
that referenced
this pull request
Nov 24, 2025
### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (#15712) (overlookmotel) ### 🚀 Features - 0c1f82b linter/plugins: Add `tokens` property to `Program` (#16020) (overlookmotel) - 6cff132 span: Add `Span::merge_within` method (#15869) (sapphi-red) - 102365d allocator/vec: Add `Vec::into_bump_slice` method (#15770) (Dunqing) ### 🐛 Bug Fixes - e2ca770 codegen: Add support for printing type arguments in new expressions (#15963) (Ives van Hoorne) - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (#16014) (overlookmotel) - 622cb5e parser: Preserve legal comments with @preserve/@license when preceded by other annotations (#15929) (copilot-swe-agent) - 7c46a9e transformer/tagged-template-transform: Handle `\n` escape sequences (#15830) (Dunqing) - f386efc minifier: Avoid generating invalid spans (#15778) (sapphi-red) - d4ff004 parser: Forbid invalid modifiers on `module` and `global` (#15723) (overlookmotel) - 2191ae9 semantic: Allow reserved keywords in typescript ambient contexts (#15495) (sapphi-red) - 7d1ebad isolated-declarations: Incorrect nested namespace output in isolated declarations (#15800) (copilot-swe-agent) ### ⚡ Performance - b4b0ed8 transformer/typescript: Reverse order of checks (#15722) (overlookmotel) ### 📚 Documentation - c81a331 data_structures: Doc comments on fields of `Stack` (#15793) (overlookmotel) - cfae31d allocator: Use `allocator` as var name in examples (#15781) (overlookmotel) Co-authored-by: Boshen <[email protected]>
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…5770) Add an `into_bump_slice` method in `Vec` that directly delegates to the InnerVec's `into_bump_slice`. The reason we should add this method rather than using `InnerVec`'s `into_bump_slice` directly is that the method requires taking `self`, which doesn't work with `Deref`. The method comments are copied from InnerVec's, and the example has been changed to make it work with the current Vec.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
### 💥 BREAKING CHANGES - cbb27fd ast: [**BREAKING**] Add `TSGlobalDeclaration` type (oxc-project#15712) (overlookmotel) ### 🚀 Features - 0c1f82b linter/plugins: Add `tokens` property to `Program` (oxc-project#16020) (overlookmotel) - 6cff132 span: Add `Span::merge_within` method (oxc-project#15869) (sapphi-red) - 102365d allocator/vec: Add `Vec::into_bump_slice` method (oxc-project#15770) (Dunqing) ### 🐛 Bug Fixes - e2ca770 codegen: Add support for printing type arguments in new expressions (oxc-project#15963) (Ives van Hoorne) - 2bd3cb6 apps, editors, napi: Fix `oxlint-disable` comments (oxc-project#16014) (overlookmotel) - 622cb5e parser: Preserve legal comments with @preserve/@license when preceded by other annotations (oxc-project#15929) (copilot-swe-agent) - 7c46a9e transformer/tagged-template-transform: Handle `\n` escape sequences (oxc-project#15830) (Dunqing) - f386efc minifier: Avoid generating invalid spans (oxc-project#15778) (sapphi-red) - d4ff004 parser: Forbid invalid modifiers on `module` and `global` (oxc-project#15723) (overlookmotel) - 2191ae9 semantic: Allow reserved keywords in typescript ambient contexts (oxc-project#15495) (sapphi-red) - 7d1ebad isolated-declarations: Incorrect nested namespace output in isolated declarations (oxc-project#15800) (copilot-swe-agent) ### ⚡ Performance - b4b0ed8 transformer/typescript: Reverse order of checks (oxc-project#15722) (overlookmotel) ### 📚 Documentation - c81a331 data_structures: Doc comments on fields of `Stack` (oxc-project#15793) (overlookmotel) - cfae31d allocator: Use `allocator` as var name in examples (oxc-project#15781) (overlookmotel) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
into_bump_slicemethod inVecthat directly delegates to the InnerVec'sinto_bump_slice. The reason we should add this method rather than usingInnerVec'sinto_bump_slicedirectly is that the method requires takingself, which doesn't work withDeref.The method comments are copied from InnerVec's, and the example has been changed to make it work with the current Vec.