refactor(language_server): Add formatter and linter features#15767
Merged
graphite-app[bot] merged 1 commit intomainfrom Nov 17, 2025
Merged
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the language server to make the formatter and linter features optional and independently configurable, allowing for smaller binary sizes and more flexible compilation options.
- Added Cargo feature flags for
formatterandlinterwith both enabled by default - Made
oxc_formatterandoxc_linteroptional dependencies - Added conditional compilation gates throughout the codebase for feature-specific code
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_language_server/src/main.rs | Updated to conditionally push tools based on enabled features |
| crates/oxc_language_server/src/lib.rs | Added feature gates for formatter and linter module declarations and exports |
| crates/oxc_language_server/Cargo.toml | Made formatter and linter dependencies optional and defined corresponding features with both in default |
| apps/oxlint/Cargo.toml | Explicitly enabled the linter feature for oxc_language_server dependency |
| Cargo.toml | Set default-features = false for workspace-level oxc_language_server dependency to allow consumers to opt-in to features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leaysgur
force-pushed
the
11-17-refactor_language_server_add_formatter_and_linter_features
branch
2 times, most recently
from
39ff395 to
1b35906
Compare
2 tasks
Member
|
We have #15738 down the road. |
Sysix
approved these changes
Nov 17, 2025
Member
Sysix
left a comment
Sysix
left a comment
There was a problem hiding this comment.
oh here are the features flags :)
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
Currently, there is 2 ways to start LS for oxc apps. - `oxc_language_server` - `oxlint --lsp` - (`oxfmt --lsp` will be added soon) Having duplicates are fine for now, but `ServerFormatter` (and `oxc_formatter`) should not bundled in `oxlint --lsp` case. This PR adds `linter` and `formatter` features to exclude. For `oxc_language_server`, both features are enabled by default, keep it as-is.
graphite-app
bot
force-pushed
the
11-17-refactor_language_server_add_formatter_and_linter_features
branch
from
1b35906 to
03e8f28
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
Support `--lsp`, fixes #15739 - Implementation still lives in `oxc_language_server` - The same as `oxlint --lsp` - But now we can remove `oxc_language_server`'s `bin` - For Rust CLI, `.await` with `tokio` - For JS CLI, `napi-rs` automatically wraps with `tokio` --- Now I'm seeing 2 problems: - For JS CLI, `node ./dist/cli.js --lsp` does not work - Instead of waiting LSP message, just panics with error - `{"jsonrpc":"2.0","error":{"code":-32700,"message":"Parse error"},"id":null}` - `import process2 from "process";` in bundled file makes this happen, but I don't know why - 👉🏻 Fixed by import `prettier` lazily... - `oxc_linter` is also bundled with `oxfmt` - via `oxc_language_server` - 👉🏻 #15767
Currently, there is 2 ways to start LS for oxc apps. - `oxc_language_server` - `oxlint --lsp` - (`oxfmt --lsp` will be added soon) Having duplicates are fine for now, but `ServerFormatter` (and `oxc_formatter`) should not bundled in `oxlint --lsp` case. This PR adds `linter` and `formatter` features to exclude. For `oxc_language_server`, both features are enabled by default, keep it as-is.
graphite-app
bot
force-pushed
the
11-17-refactor_language_server_add_formatter_and_linter_features
branch
from
03e8f28 to
f1c62b9
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Nov 17, 2025
Support `--lsp`, fixes #15739 - Implementation still lives in `oxc_language_server` - The same as `oxlint --lsp` - But now we can remove `oxc_language_server`'s `bin` - For Rust CLI, `.await` with `tokio` - For JS CLI, `napi-rs` automatically wraps with `tokio` --- Now I'm seeing 2 problems: - For JS CLI, `node ./dist/cli.js --lsp` does not work - Instead of waiting LSP message, just panics with error - `{"jsonrpc":"2.0","error":{"code":-32700,"message":"Parse error"},"id":null}` - `import process2 from "process";` in bundled file makes this happen, but I don't know why - 👉🏻 Fixed by import `prettier` lazily... - `oxc_linter` is also bundled with `oxfmt` - via `oxc_language_server` - 👉🏻 #15767
graphite-app
bot
deleted the
11-17-refactor_language_server_add_formatter_and_linter_features
branch
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
…ject#15767) Currently, there is 2 ways to start LS for oxc apps. - `oxc_language_server` - `oxlint --lsp` - (`oxfmt --lsp` will be added soon) Having duplicates are fine for now, but `ServerFormatter` (and `oxc_formatter`) should not bundled in `oxlint --lsp` case. This PR adds `linter` and `formatter` features to exclude. For `oxc_language_server`, both features are enabled by default, keep it as-is.
taearls
pushed a commit
to taearls/oxc
that referenced
this pull request
Dec 11, 2025
Support `--lsp`, fixes oxc-project#15739 - Implementation still lives in `oxc_language_server` - The same as `oxlint --lsp` - But now we can remove `oxc_language_server`'s `bin` - For Rust CLI, `.await` with `tokio` - For JS CLI, `napi-rs` automatically wraps with `tokio` --- Now I'm seeing 2 problems: - For JS CLI, `node ./dist/cli.js --lsp` does not work - Instead of waiting LSP message, just panics with error - `{"jsonrpc":"2.0","error":{"code":-32700,"message":"Parse error"},"id":null}` - `import process2 from "process";` in bundled file makes this happen, but I don't know why - 👉🏻 Fixed by import `prettier` lazily... - `oxc_linter` is also bundled with `oxfmt` - via `oxc_language_server` - 👉🏻 oxc-project#15767
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is 2 ways to start LS for oxc apps.
oxc_language_serveroxlint --lspoxfmt --lspwill be added soon)Having duplicates are fine for now, but
ServerFormatter(andoxc_formatter) should not bundled inoxlint --lspcase.This PR adds
linterandformatterfeatures to exclude.For
oxc_language_server, both features are enabled by default, keep it as-is.