Skip to content

Comments

test(linter/switch-case-braces): add test for comment between case expression and colon#15754

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-16-test_linter_switch-case-braces_add_test_for_comment_between_case_expression_and_colon
Nov 16, 2025
Merged

test(linter/switch-case-braces): add test for comment between case expression and colon#15754
graphite-app[bot] merged 1 commit intomainfrom
c/11-16-test_linter_switch-case-braces_add_test_for_comment_between_case_expression_and_colon

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 16, 2025

Adds a test case to ensure the fixer correctly handles switch cases where a comment appears between the test expression and the colon, such as case 'a'/* comment */:. This regression test verifies the fix for the is_inside_comment off-by-one bug.

@github-actions github-actions bot added A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Nov 16, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 16, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Nov 16, 2025
Merged
@camc314 camc314 marked this pull request as ready for review November 16, 2025 23:12
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 16, 2025 •
edited
Loading

Merge activity

@camc314
test(linter/switch-case-braces): add test for comment between case ex…
5815c08 
…pression and colon (#15754)

Adds a test case to ensure the fixer correctly handles switch cases where a comment appears between the test expression and the colon, such as `case 'a'/* comment */:`. This regression test verifies the fix for the `is_inside_comment` off-by-one bug.
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15754 will not alter performance

Comparing c/11-16-test_linter_switch-case-braces_add_test_for_comment_between_case_expression_and_colon (5815c08) with main (1decd57)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (e0728fa) during the generation of this report, so 1decd57 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app bot force-pushed the c/11-16-fix_ast_exclude_comment_end_position_from_is_inside_comment_check branch from bade05c to e0728fa Compare November 16, 2025 23:17
@graphite-app graphite-app bot force-pushed the c/11-16-test_linter_switch-case-braces_add_test_for_comment_between_case_expression_and_colon branch from 54f9675 to 5815c08 Compare November 16, 2025 23:17
Base automatically changed from c/11-16-fix_ast_exclude_comment_end_position_from_is_inside_comment_check to main November 16, 2025 23:22
@graphite-app graphite-app bot merged commit 5815c08 into main Nov 16, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/11-16-test_linter_switch-case-braces_add_test_for_comment_between_case_expression_and_colon branch November 16, 2025 23:23
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
@camc314 @taearls
test(linter/switch-case-braces): add test for comment between case ex…
b9a934c 
…pression and colon (oxc-project#15754)

Adds a test case to ensure the fixer correctly handles switch cases where a comment appears between the test expression and the colon, such as `case 'a'/* comment */:`. This regression test verifies the fix for the `is_inside_comment` off-by-one bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314