Skip to content

feat(docs): improve rendering of oxlintrc schema markdown#15571

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-10-feat_docs_improve_rendering_of_oxlintrc_schema_markdown
Nov 11, 2025
Merged

feat(docs): improve rendering of oxlintrc schema markdown#15571
graphite-app[bot] merged 1 commit intomainfrom
c/11-10-feat_docs_improve_rendering_of_oxlintrc_schema_markdown

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 10, 2025

No description provided.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 10, 2025
@camc314 camc314 marked this pull request as ready for review November 10, 2025 23:35
Copilot AI review requested due to automatic review settings November 10, 2025 23:35
Copy link
Contributor Author

camc314 commented Nov 10, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the rendering of oxlintrc schema markdown by adding support for anyOf subschemas. Previously, fields with anyOf schemas weren't being rendered with proper type information. The changes introduce logic to handle anyOf by extracting instance types from the subschemas and rendering them as union types (e.g., object | null).

  • Added anyOf handling in render_sub_schema to generate union type descriptions
  • Modified render_schema_impl to check for and render subschemas at the top level before other processing
  • Updated snapshot with new type information for fields like overrides[n].env, overrides[n].globals, overrides[n].plugins, plugins, and settings types

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
tasks/website/src/linter/json_schema.rs Implements anyOf subschema rendering logic to generate union type strings from multiple schema options
tasks/website/src/linter/snapshots/schema_markdown.snap Updates snapshot with new type information for fields that use anyOf schemas

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/11-10-feat_docs_improve_rendering_of_oxlintrc_schema_markdown branch from fe03b5b to 1741204 Compare November 11, 2025 15:48
@graphite-app graphite-app bot merged commit 1741204 into main Nov 11, 2025
18 checks passed
@graphite-app graphite-app bot deleted the c/11-10-feat_docs_improve_rendering_of_oxlintrc_schema_markdown branch November 11, 2025 15:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments