Skip to content

Comments

perf(formatter): optimize formatting literal string#15380

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-06-perf_formatter_optimize_formatting_literal_string
Nov 7, 2025
Merged

perf(formatter): optimize formatting literal string#15380
graphite-app[bot] merged 1 commit intomainfrom
11-06-perf_formatter_optimize_formatting_literal_string

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 6, 2025

No description provided.

Copy link
Member Author

Dunqing commented Nov 6, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025

CodSpeed Performance Report

Merging #15380 will not alter performance

Comparing 11-06-perf_formatter_optimize_formatting_literal_string (c39977d) with 11-06-perf_formatter_memoize_text_width_for_formatelemetn_text (2b15086)

Summary

✅ 33 untouched
⏩ 4 skipped1

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Dunqing Dunqing force-pushed the 11-06-perf_formatter_memoize_text_width_for_formatelemetn_text branch from 92465a1 to 2b15086 Compare November 6, 2025 16:02
@Dunqing Dunqing force-pushed the 11-06-perf_formatter_optimize_formatting_literal_string branch 4 times, most recently from 0fd799f to c39977d Compare November 7, 2025 01:04
@Dunqing Dunqing marked this pull request as ready for review November 7, 2025 01:06
@Dunqing Dunqing requested a review from leaysgur November 7, 2025 01:06
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
Copy link
Member

leaysgur commented Nov 7, 2025

Merge activity

  • Nov 7, 1:08 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 7, 1:17 AM UTC: leaysgur added this pull request to the Graphite merge queue.
  • Nov 7, 1:26 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #15365.
  • Nov 7, 1:33 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 7, 1:33 AM UTC: leaysgur added this pull request to the Graphite merge queue.
  • Nov 7, 1:34 AM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #15366.
  • Nov 7, 1:54 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 7, 2:05 AM UTC: Dunqing added this pull request to the Graphite merge queue.
  • Nov 7, 2:05 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 11-06-perf_formatter_memoize_text_width_for_formatelemetn_text branch from 2b15086 to 8f25a0e Compare November 7, 2025 01:21
@graphite-app graphite-app bot force-pushed the 11-06-perf_formatter_optimize_formatting_literal_string branch from c39977d to 635ac8e Compare November 7, 2025 01:22
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@Dunqing Dunqing force-pushed the 11-06-perf_formatter_optimize_formatting_literal_string branch from 635ac8e to f30ce4b Compare November 7, 2025 01:58
Base automatically changed from 11-06-perf_formatter_memoize_text_width_for_formatelemetn_text to main November 7, 2025 02:00
@graphite-app graphite-app bot merged commit f30ce4b into main Nov 7, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-06-perf_formatter_optimize_formatting_literal_string branch November 7, 2025 02:05
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants