Skip to content

Comments

feat(formatter): remove FormatElement::LocatedTokenText#15367

Merged
graphite-app[bot] merged 1 commit intomainfrom
11-06-feat_formatter_remove_formatelement_locatedtokentext
Nov 7, 2025
Merged

feat(formatter): remove FormatElement::LocatedTokenText#15367
graphite-app[bot] merged 1 commit intomainfrom
11-06-feat_formatter_remove_formatelement_locatedtokentext

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Nov 6, 2025 •
edited
Loading

The last usage has been removed in #15366, and it is no longer useful to us, so remove it.

The performance gains from the FormatElement enum, as its size has been reduced from 40 to 24.

@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Nov 6, 2025
This was referenced Nov 6, 2025
Merged
Merged
Merged
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Nov 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Nov 6, 2025
Merged
@Dunqing Dunqing force-pushed the 11-06-perf_formatter_avoid_allocation_for_syntaxtokencowslice branch from cf80a9a to 7d5e202 Compare November 6, 2025 07:20
@Dunqing Dunqing force-pushed the 11-06-feat_formatter_remove_formatelement_locatedtokentext branch from c29321a to ca50c5b Compare November 6, 2025 07:20
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15367 will improve performances by 14.82%

Comparing 11-06-feat_formatter_remove_formatelement_locatedtokentext (cd23bd6) with 11-06-perf_formatter_avoid_allocation_for_syntaxtokencowslice (7d5e202)

Summary

⚡ 4 improvements
✅ 29 untouched
⏩ 4 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
⚡ Simulation formatter[RadixUIAdoptionSection.jsx] 571.7 µs 523.1 µs +9.3%
⚡ Simulation formatter[binder.ts] 23.7 ms 22.2 ms +6.86%
⚡ Simulation formatter[cal.com.tsx] 208.1 ms 181.2 ms +14.82%
⚡ Simulation formatter[react.development.js] 12 ms 10.7 ms +12.16%

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Dunqing Dunqing force-pushed the 11-06-feat_formatter_remove_formatelement_locatedtokentext branch from ca50c5b to cd23bd6 Compare November 6, 2025 07:57
This was referenced Nov 6, 2025
Merged
Merged
Merged
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@Dunqing Dunqing mentioned this pull request Nov 7, 2025
Merged
@leaysgur leaysgur marked this pull request as ready for review November 7, 2025 01:17
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 7, 2025 •
edited
Loading

Merge activity

@Dunqing
feat(formatter): remove FormatElement::LocatedTokenText (#15367)
88c7530 
The last usage has been removed in #15366, and it is no longer useful to us, so remove it.

The performance gains from the `FormatElement` enum, as its size has been reduced from `40` to `24`.
@graphite-app graphite-app bot force-pushed the 11-06-perf_formatter_avoid_allocation_for_syntaxtokencowslice branch from 7d5e202 to f913543 Compare November 7, 2025 01:20
@graphite-app graphite-app bot force-pushed the 11-06-feat_formatter_remove_formatelement_locatedtokentext branch from cd23bd6 to 88c7530 Compare November 7, 2025 01:20
@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Nov 7, 2025
Base automatically changed from 11-06-perf_formatter_avoid_allocation_for_syntaxtokencowslice to main November 7, 2025 01:53
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@graphite-app graphite-app bot merged commit 88c7530 into main Nov 7, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 11-06-feat_formatter_remove_formatelement_locatedtokentext branch November 7, 2025 01:58
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 7, 2025
@Boshen Boshen mentioned this pull request Nov 7, 2025
Merged
@Dunqing Dunqing mentioned this pull request Nov 7, 2025
Closed
@Boshen Boshen mentioned this pull request Nov 10, 2025
Merged
@robertkirkman robertkirkman mentioned this pull request Nov 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

No one assigned

Labels

A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Dunqing