Skip to content

Comments

perf(linter): no-dupe-class-members: only run when there are any classes#14867

Merged
graphite-app[bot] merged 1 commit intomainfrom
10-21-perf_linter_no-dupe-class-members_only_run_when_there_are_any_classes
Oct 22, 2025
Merged

perf(linter): no-dupe-class-members: only run when there are any classes#14867
graphite-app[bot] merged 1 commit intomainfrom
10-21-perf_linter_no-dupe-class-members_only_run_when_there_are_any_classes

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Oct 21, 2025 •
edited
Loading

Similar to #14865. Allows removing this rule from the array of rules if there are no classes in the file.

Benchmarks don't really show any difference here, but it might just be because we haven't yet crossed an allocation threshold (i.e., once we remove enough rules, we'll see a diff)

@camchenry Graphite App
Copy link
Member Author

camchenry commented Oct 21, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 21, 2025
Merged
Merged
@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 21, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 21, 2025

CodSpeed Performance Report

Merging #14867 will not alter performance

Comparing 10-21-perf_linter_no-dupe-class-members_only_run_when_there_are_any_classes (77d9d99) with 10-21-perf_linter_no-this-before-super_only_run_when_file_contains_super_or_this (18d736f)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on 10-21-perf_linter_no-this-before-super_only_run_when_file_contains_super_or_this (18d736f) during the generation of this report, so 8834045 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This was referenced Oct 21, 2025
Merged
Closed
Merged
@camchenry camchenry marked this pull request as ready for review October 22, 2025 02:24
@camchenry camchenry requested a review from camc314 as a code owner October 22, 2025 02:24
@camchenry camchenry mentioned this pull request Oct 22, 2025
Closed
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Oct 22, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Oct 22, 2025 •
edited by graphite-app bot
Loading

Merge activity

@camchenry
perf(linter): no-dupe-class-members: only run when there are any cl…
5493278 
…asses (#14867)

Similar to #14865. Allows removing this rule from the array of rules if there are no classes in the file.

Benchmarks don't really show any difference here, but it might just be because we haven't yet crossed an allocation threshold (i.e., once we remove enough rules, we'll see a diff)
@graphite-app graphite-app bot force-pushed the 10-21-perf_linter_no-this-before-super_only_run_when_file_contains_super_or_this branch from 18d736f to ef53462 Compare October 22, 2025 08:19
@graphite-app graphite-app bot force-pushed the 10-21-perf_linter_no-dupe-class-members_only_run_when_there_are_any_classes branch from 77d9d99 to 5493278 Compare October 22, 2025 08:20
Base automatically changed from 10-21-perf_linter_no-this-before-super_only_run_when_file_contains_super_or_this to main October 22, 2025 08:23
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Oct 22, 2025
@graphite-app graphite-app bot merged commit 5493278 into main Oct 22, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 10-21-perf_linter_no-dupe-class-members_only_run_when_there_are_any_classes branch October 22, 2025 08:24
@camc314 camc314 self-assigned this Oct 22, 2025
@Boshen Boshen mentioned this pull request Oct 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camchenry @camc314