Skip to content

docs(linter): clarify default status for type aware rules#14587

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/10-14-docs_linter_clarify_default_status_for_type_aware_rules
Oct 14, 2025
Merged

docs(linter): clarify default status for type aware rules#14587
graphite-app[bot] merged 1 commit intomainfrom
c/10-14-docs_linter_clarify_default_status_for_type_aware_rules

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Oct 14, 2025

fixes #13676

@camc314 camc314 marked this pull request as ready for review October 14, 2025 08:19
Copilot AI review requested due to automatic review settings October 14, 2025 08:19
@github-actions github-actions bot added the C-docs Category - Documentation. Related to user-facing or internal documentation label Oct 14, 2025
Copy link
Copy Markdown
Contributor Author

camc314 commented Oct 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Clarify the default status message for type-aware linter rules in the docs.

  • Add a conditional message when a rule is default-on specifically under type-aware linting.
  • Preserve the existing default-on message for non-type-aware rules.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@camc314 camc314 self-assigned this Oct 14, 2025
@camc314 camc314 force-pushed the c/10-14-docs_linter_clarify_default_status_for_type_aware_rules branch from 4dde575 to 906eab4 Compare October 14, 2025 08:20
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented Oct 14, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/10-14-docs_linter_clarify_default_status_for_type_aware_rules branch from 906eab4 to ba28b89 Compare October 14, 2025 08:27
@graphite-app graphite-app bot merged commit ba28b89 into main Oct 14, 2025
18 checks passed
@graphite-app graphite-app bot deleted the c/10-14-docs_linter_clarify_default_status_for_type_aware_rules branch October 14, 2025 08:33
camchenry pushed a commit that referenced this pull request Oct 29, 2025
Inspired by #14587, the command flag was missing for them too.

Expected: `oxlint --type-aware --deny typescript/await-thenable`
Actual: `oxlint --deny typescript/await-thenable`

<img width="840" height="259" alt="image"
src="https://github.com/user-attachments/assets/b9c5dc4b-5dfc-4558-a6e9-5187a60df8f2"
/>

---------

Signed-off-by: Alexander Lichter <[email protected]>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(linter): rule details pages should include info about whether they are type aware

2 participants